Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove capacities from results #74

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

MaGering
Copy link
Collaborator

Resolves #72

With this PR capacity, from_to_capacity, to_from_capacity and storage_capacity appear no longer in the postprocessed results.

@MaGering MaGering requested a review from jnnr October 10, 2022 15:54
Copy link
Collaborator

@jnnr jnnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MaGering! Looks good. Need to fix the tests, still. One of them is easy: Add matplotlib to oemoflex' requirements to fix the tests in test_plots.py. The other one is an ImportError in oemof.tabular and has to be fixed there. I will take care of that.

@jnnr
Copy link
Collaborator

jnnr commented Oct 12, 2022

Thanks @MaGering! Ready to merge.

@MaGering MaGering merged commit 3431118 into dev Oct 12, 2022
@MaGering MaGering deleted the feature/remove_cap_from_results branch October 12, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capacity appears in results, but is a parameter
2 participants