Skip to content

Update occursAt function to handle DateTime in different timezone #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016
Merged

Update occursAt function to handle DateTime in different timezone #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ public function occursOn($date)
*/
public function occursAt($date)
{
$date = self::parseDate($date);
$date = self::parseDate($date)->setTimezone($this->dtstart->getTimezone());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will create problems because you are overriding the timezone if one was provided. You should only set the timezone only if $date does not already contain a timezone.


if ( in_array($date, $this->cache) ) {
// in the cache (whether cache is complete or not)
Expand Down