Skip to content

Conversation

lphilps
Copy link
Contributor

@lphilps lphilps commented Oct 13, 2016

in _parseKey, the replace function should replace all occurrences of /
with ., not just the first occurrence.

rmariuzzo and others added 3 commits August 26, 2016 08:08
in _parseKey, the replace function should replace all occurrences of /
with ., not just the first occurrence.
@rmariuzzo rmariuzzo changed the base branch from master to develop October 13, 2016 20:43
Copy link
Owner

@rmariuzzo rmariuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @lphilps. Will plan to release early this week.

@lphilps
Copy link
Contributor Author

lphilps commented Oct 13, 2016

NP. Thanks for creating this package in the first place. It's going to be very useful in one of my projects!

@rmariuzzo
Copy link
Owner

Glad to hear that!

@rmariuzzo rmariuzzo added this to the 1.1.2 milestone Oct 13, 2016
@rmariuzzo rmariuzzo added the bug label Oct 13, 2016
Copy link
Owner

@rmariuzzo rmariuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmariuzzo rmariuzzo merged commit 846fd90 into rmariuzzo:develop Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants