[Feature] android: use FlutterEngineGroup for better perf #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
chipweinberger
changed the title
|
Thanks @chipweinberger - as you saw, this has been on my radar for quite a long time. I appreciate the effort! I've only just moved house so I'm a bit off schedule, give me a couple of days to look through this and I'll review soon. |
|
No worries. good luck with the move Nick! |
|
hope the move went well @nmfisher , just wanted to ping you again. Also, I'm open to being a contributer if you prefer that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, use FlutterEngineGroup for better perf on android.
There is a separate PR for iOS: #151
this closes
#149
#111
#73
I've tested these changes on Android 13 and Flutter 3.16.8
About me, I am the maintainer of these packages, so I am pretty familiar with flutter plugins