-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightspeed colors seem off #6
Comments
Hi again, sorry about this, I didn't know about the guidelines posted by the author so I just tried out something similar to Nord.nvim. I'll read it tonight and try to come up with something that's stylized but also fits the guidelines! |
No need to apologize, and thank you! |
Looks great IMO! |
Alright thanks, I just pushed a commit so let me know if you still see any problems! |
Way easier to use. Thank you for the changes! |
Some of the colors Onenord uses for lightspeed.nvim cause issues when using the plugin. For example, Lightspeed highlights all of the unique characters in the viewport, but these are quite hard to see when using Onenord:
For comparison, here's the same view when using the Nordfox theme from nightfox.nvim:
Likewise, the colors used when jumping are a bit confusing. Here, the first character indicates a match, and the second character indicates the character that will jump to that match, but they're so similar that it's hard to know which is which at a glance:
I think Nordfox doesn't modify these colors at all, so they're pretty ugly, but you can see that there's a lot of contrast between the first and second characters, which makes it easier to parse:
I'd put in a PR, but I'm frankly inept when it comes to anything color-related. I saw that the author of Lightspeed just updated the guidelines for color scheme integration, so maybe that could provide some guidance.
The text was updated successfully, but these errors were encountered: