Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightspeed colors seem off #6

Closed
jose-elias-alvarez opened this issue Nov 3, 2021 · 6 comments
Closed

Lightspeed colors seem off #6

jose-elias-alvarez opened this issue Nov 3, 2021 · 6 comments

Comments

@jose-elias-alvarez
Copy link
Contributor

Some of the colors Onenord uses for lightspeed.nvim cause issues when using the plugin. For example, Lightspeed highlights all of the unique characters in the viewport, but these are quite hard to see when using Onenord:

Screen Shot 2021-11-03 at 12 18 02 PM

For comparison, here's the same view when using the Nordfox theme from nightfox.nvim:

Screen Shot 2021-11-03 at 12 18 16 PM

Likewise, the colors used when jumping are a bit confusing. Here, the first character indicates a match, and the second character indicates the character that will jump to that match, but they're so similar that it's hard to know which is which at a glance:

Screen Shot 2021-11-03 at 12 18 34 PM

I think Nordfox doesn't modify these colors at all, so they're pretty ugly, but you can see that there's a lot of contrast between the first and second characters, which makes it easier to parse:

Screen Shot 2021-11-03 at 12 18 56 PM

I'd put in a PR, but I'm frankly inept when it comes to anything color-related. I saw that the author of Lightspeed just updated the guidelines for color scheme integration, so maybe that could provide some guidance.

@rmehri01
Copy link
Owner

rmehri01 commented Nov 3, 2021

Hi again, sorry about this, I didn't know about the guidelines posted by the author so I just tried out something similar to Nord.nvim. I'll read it tonight and try to come up with something that's stylized but also fits the guidelines!

@jose-elias-alvarez
Copy link
Contributor Author

No need to apologize, and thank you!

@rmehri01
Copy link
Owner

rmehri01 commented Nov 3, 2021

I had some time to look at it so it's definitely more usable now but I'm not sure about the colors either, for now it is just a toned down version of the original. Any thoughts?

Original:
Screen Shot 2021-11-03 at 11 27 06 AM

Onenord:
Screen Shot 2021-11-03 at 12 00 39 PM

Fixed unique characters:
Screen Shot 2021-11-03 at 12 00 53 PM

@jose-elias-alvarez
Copy link
Contributor Author

Looks great IMO!

@rmehri01
Copy link
Owner

rmehri01 commented Nov 3, 2021

Alright thanks, I just pushed a commit so let me know if you still see any problems!

@jose-elias-alvarez
Copy link
Contributor Author

Way easier to use. Thank you for the changes!

@rmehri01 rmehri01 closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants