Error when building native extension

[chanks]

Hi -

Super excited for this faster parser, but I'm running into a problem when I try to install it. This may have been my own error, since I don't know a ton about C, but I managed to make and install libgraphqlparser without any apparent issue, so I'm not sure what the problem is. This is on Linux Mint, btw.

$ gem install graphql-libgraphqlparser -v '0.1.3'
Building native extensions.  This could take a while...
ERROR:  Error installing graphql-libgraphqlparser:
    ERROR: Failed to build gem native extension.

    current directory: /home/chris/.rvm/gems/ruby-2.3.0/gems/graphql-libgraphqlparser-0.1.3/ext/libgraphqlparser
/home/chris/.rvm/rubies/ruby-2.3.0/bin/ruby -r ./siteconf20160307-19445-1ux8w1r.rb extconf.rb
checking for main() in -lgraphqlparser... yes
creating Makefile

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /home/chris/.rvm/gems/ruby-2.3.0/extensions/x86_64-linux/2.3.0/graphql-libgraphqlparser-0.1.3/mkmf.log

current directory: /home/chris/.rvm/gems/ruby-2.3.0/gems/graphql-libgraphqlparser-0.1.3/ext/libgraphqlparser
make "DESTDIR=" clean

current directory: /home/chris/.rvm/gems/ruby-2.3.0/gems/graphql-libgraphqlparser-0.1.3/ext/libgraphqlparser
make "DESTDIR="
compiling libgraphqlparser.c
compiling visitor_functions.c
visitor_functions.c: In function ‘enum_value_begin_visit’:
visitor_functions.c:281:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   const char* str_value = GraphQLAstEnumValue_get_value(node);
   ^
linking shared-object libgraphqlparser.so
./libgraphqlparser.so: file not recognized: File truncated
collect2: error: ld returned 1 exit status
make: *** [libgraphqlparser.so] Error 1

make failed, exit code 2

Gem files will remain installed in /home/chris/.rvm/gems/ruby-2.3.0/gems/graphql-libgraphqlparser-0.1.3 for inspection.
Results logged to /home/chris/.rvm/gems/ruby-2.3.0/extensions/x86_64-linux/2.3.0/graphql-libgraphqlparser-0.1.3/gem_make.out

The log it directs me to reads:

$ cat /home/chris/.rvm/gems/ruby-2.3.0/extensions/x86_64-linux/2.3.0/graphql-libgraphqlparser-0.1.3/mkmf.log
have_library: checking for main() in -lgraphqlparser... -------------------- yes

"gcc -o conftest -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0/x86_64-linux -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0/ruby/backward -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0 -I. -I/usr/local/include/graphqlparser     -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializers -Wunused-variable -Wpointer-arith -Wwrite-strings -Wdeclaration-after-statement -Wimplicit-function-declaration -Wdeprecated-declarations -Wno-packed-bitfield-compat  -fPIC conftest.c  -L. -L/home/chris/.rvm/rubies/ruby-2.3.0/lib -Wl,-R/home/chris/.rvm/rubies/ruby-2.3.0/lib -L/usr/local/lib -Wl,-R/usr/local/lib -L. -fstack-protector -rdynamic -Wl,-export-dynamic     -Wl,-R/home/chris/.rvm/rubies/ruby-2.3.0/lib -L/home/chris/.rvm/rubies/ruby-2.3.0/lib -lruby  -lpthread -ldl -lcrypt -lm   -lc"
checked program was:
/* begin */
1: #include "ruby.h"
2: 
3: int main(int argc, char **argv)
4: {
5:   return 0;
6: }
/* end */

"gcc -o conftest -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0/x86_64-linux -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0/ruby/backward -I/home/chris/.rvm/rubies/ruby-2.3.0/include/ruby-2.3.0 -I. -I/usr/local/include/graphqlparser     -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializers -Wunused-variable -Wpointer-arith -Wwrite-strings -Wdeclaration-after-statement -Wimplicit-function-declaration -Wdeprecated-declarations -Wno-packed-bitfield-compat  -fPIC conftest.c  -L. -L/home/chris/.rvm/rubies/ruby-2.3.0/lib -Wl,-R/home/chris/.rvm/rubies/ruby-2.3.0/lib -L/usr/local/lib -Wl,-R/usr/local/lib -L. -fstack-protector -rdynamic -Wl,-export-dynamic     -Wl,-R/home/chris/.rvm/rubies/ruby-2.3.0/lib -L/home/chris/.rvm/rubies/ruby-2.3.0/lib -lruby -lgraphqlparser  -lpthread -ldl -lcrypt -lm   -lc"
checked program was:
/* begin */
 1: #include "ruby.h"
 2: 
 3: /*top*/
 4: extern int t(void);
 5: int main(int argc, char **argv)
 6: {
 7:   if (argc > 1000000) {
 8:     printf("%p", &t);
 9:   }
10: 
11:   return 0;
12: }
13: int t(void) { void ((*volatile p)()); p = (void ((*)()))main; return !p; }
/* end */

--------------------

If anyone has some advice on where to look or what to try, it'd be much appreciated.

Thanks!

[chanks]

So, I'm thinking that it's my installation of libgraphqlparser that's messed up. When I do the make install I get:

[  5%] [FLEX][GraphQLScanner] Building scanner with flex 2.5.35
[ 10%] Generating Ast.h
[ 15%] Generating Ast.cpp
[ 21%] Generating AstVisitor.h
[ 26%] Generating c/GraphQLAst.h
[ 31%] Generating c/GraphQLAst.cpp
[ 36%] Generating c/GraphQLAstForEachConcreteType.h
[ 42%] [BISON][graphqlparser] Building parser with bison 3.0.2
parser.ypp:233.17-43: warning: unset value: $$ [-Wother]
 start:          document  { *outAST = $1; }
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
parser.ypp:348.23-26: warning: unused value: $2 [-Wother]
                 "..." "on" type_condition directives_opt selection_set { $$ = new InlineFragment(@$, $3, $4, $5); }
                       ^^^^
parser.ypp:353.17-26: warning: unused value: $1 [-Wother]
                 "fragment" fragment_name "on" type_condition directives_opt selection_set { $$ = new FragmentDefinition(@$, $2, $4, $5, $6); }
                 ^^^^^^^^^^
parser.ypp:353.42-45: warning: unused value: $3 [-Wother]
                 "fragment" fragment_name "on" type_condition directives_opt selection_set { $$ = new FragmentDefinition(@$, $2, $4, $5, $6); }
                                          ^^^^
parser.ypp:388.17-20: warning: unused value: $1 [-Wother]
 boolean_value:  TRUE { $$ = new BooleanValue(@$, true); }
                 ^^^^
parser.ypp:389.17-21: warning: unused value: $1 [-Wother]
         |       FALSE { $$ = new BooleanValue(@$, false); }
                 ^^^^^
Scanning dependencies of target graphqlparser
[ 47%] Building CXX object CMakeFiles/graphqlparser.dir/JsonVisitor.cpp.o
[ 52%] Building CXX object CMakeFiles/graphqlparser.dir/Ast.cpp.o
[ 57%] Building CXX object CMakeFiles/graphqlparser.dir/c/GraphQLAst.cpp.o
[ 63%] Building CXX object CMakeFiles/graphqlparser.dir/c/GraphQLAstNode.cpp.o
[ 68%] Building CXX object CMakeFiles/graphqlparser.dir/c/GraphQLAstToJSON.cpp.o
[ 73%] Building CXX object CMakeFiles/graphqlparser.dir/c/GraphQLAstVisitor.cpp.o
[ 78%] Building CXX object CMakeFiles/graphqlparser.dir/c/GraphQLParser.cpp.o
[ 84%] Building CXX object CMakeFiles/graphqlparser.dir/parser.tab.cpp.o
[ 89%] Building CXX object CMakeFiles/graphqlparser.dir/lexer.cpp.o
[ 94%] Building CXX object CMakeFiles/graphqlparser.dir/GraphQLParser.cpp.o
Linking CXX shared library libgraphqlparser.so
[ 94%] Built target graphqlparser
Scanning dependencies of target dump_json_ast
[100%] Building CXX object CMakeFiles/dump_json_ast.dir/dump_json_ast.cpp.o
Linking CXX executable dump_json_ast
[100%] Built target dump_json_ast
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/include/graphqlparser/c
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstToJSON.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLParser.h
-- Installing: /usr/local/include/graphqlparser/c/GraphQLAst.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstNode.h
-- Installing: /usr/local/include/graphqlparser/c/GraphQLAstForEachConcreteType.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstVisitor.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/graphqlparser.dir
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/graphqlparser.dir/c
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/CMakeTmp
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/2.8.12.2
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/2.8.12.2/CompilerIdC
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/2.8.12.2/CompilerIdCXX
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/CMakeFiles/dump_json_ast.dir
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/python
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/python/CMakeFiles
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/go
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/ast
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/AstNode.h
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/GraphQLParser.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/test
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/syntaxdefs.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/lexer.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/AstVisitor.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLAstToJSON.h
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLParser.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLAst.h
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLAstNode.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLAstForEachConcreteType.h
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/c/GraphQLAstVisitor.h
-- Up-to-date: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/JsonVisitor.h
-- Installing: /usr/local/include/graphqlparser/libgraphqlparser-0.4.0/Ast.h
-- Installing: /usr/local/include/graphqlparser/c
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstToJSON.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLParser.h
-- Installing: /usr/local/include/graphqlparser/c/GraphQLAst.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstNode.h
-- Installing: /usr/local/include/graphqlparser/c/GraphQLAstForEachConcreteType.h
-- Up-to-date: /usr/local/include/graphqlparser/c/GraphQLAstVisitor.h
-- Up-to-date: /usr/local/include/graphqlparser/AstNode.h
-- Up-to-date: /usr/local/include/graphqlparser/GraphQLParser.h
-- Up-to-date: /usr/local/include/graphqlparser/JsonVisitor.h
-- Installing: /usr/local/include/graphqlparser/lexer.h
-- Installing: /usr/local/include/graphqlparser/location.hh
-- Installing: /usr/local/include/graphqlparser/parser.tab.hpp
-- Installing: /usr/local/include/graphqlparser/position.hh
-- Installing: /usr/local/include/graphqlparser/stack.hh
-- Up-to-date: /usr/local/include/graphqlparser/syntaxdefs.h
-- Installing: /usr/local/lib/libgraphqlparser.so

I find it very suspicious that libgraphqlparser.so is the final file listed and is also the one that the gem installation complains is truncated. I suspect the build is failing but the output isn't really making that clear.

I'm thinking this doesn't look like a bug with the gem, but it'll probably help someone else so I'll leave the issue open for now and report back with whatever I find.

[rmosolgo]

I had this same error on Travis earlier, but only when building Ruby 2.1. I ended up just removing it from the build 😬

I wonder if you're on to something there. I think I should at least rename the extension file so it's easier to see where the problem is!

I don't know a ton about C,

✋ same!

[chanks]

So, I've just been playing around with this on a fresh Ubuntu server instance, and I get the installation error when installing the gem on Ruby 2.1.8 or 2.3.0, but it installs fine on each of 2.2.0 through 2.2.4. And on that machine the make script ended the same way, after /usr/local/lib/libgraphqlparser.so, so I'm not so sure that's the problem anymore. I also ran the benchmark script successfully after installing it on 2.2.4, just to be sure.

[rmosolgo]

Renaming the extension files caused the tests to pass on 2.1 & 2.3 on Travis, want to try again? I pushed a new version, 0.1.4.

[chanks]

Yes! Thanks a lot, I'll give it a try tomorrow.

On Monday, March 7, 2016, Robert Mosolgo notifications@github.com wrote:

Renaming the extension files caused the tests to pass on 2.1 & 2.3 on
Travis, want to try again? I pushed a new version, 0.1.4.

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

[chanks]

Works great on 2.3 and Linux, thanks!