-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OperationStore index appears to fail with nil comparsion #4940
Comments
Hey, sorry for the trouble and thanks for reporting this! "Archiving" was a later addition to the OperationStore, but I certainly intended to retain backwards compatibility for systems that didn't migrate or hadn't migrated yet. I'll investigate this soon, and if you want to try migrating your database in the meantime, you can find the migration notes here: https://graphql-ruby.org/operation_store/active_record_backend.html#database-update |
Hmm - we did the migration referenced here a while ago. I can confirm that both of those columns are in the DB. But the error appears to be complaining about So it sounds like there's nothing that jumps out obviously as a step we missed, which makes me wonder if maybe we have something else slightly unexpected in our system. |
Yeah... very weird. Maybe that |
We're using Postgres 12.18! Sorry, should have included that earlier. |
No worries, thanks. I was able to replicate this issue when MySchema.operation_store.reindex I expect if you run that in a console, this view will be fixed for you. In any case, I also released graphql-pro 1.27.2 with more graceful handling for this case, printing a message suggesting that same fix. Could you try that fix, or try the new version, and let me know how it goes for you? |
Hmm - |
Hmm, I spoke prematurely - it no longer has the same error, but the index is pretty obviously incomplete. :-/ |
Derp... so sorry about that. I just released graphql-pro v1.27.3 with a fixed (and properly tested...) multi-page |
Ah ha! That got us back in shape. Thanks a ton, @rmosolgo ! |
Glad to hear it. Sorry for the trouble and thanks for working through it with me! |
Describe the bug
When loading the admin page for the OperationStore index, we get an error:
Versions
graphql
version: graphql 2.3.1, graphql-pro 1.27.1rails
(or other framework): 6.1.7.7Steps to reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
From drilling into the operation store, this appears to happen at this line:
That appears to building up the entry summary:
This makes me wonder if perhaps there's some schema migration or other operation that needs to be applied to our DB that got missed somehow?
Place full backtrace here (if a Ruby exception is involved):
Click to view exception backtrace
The text was updated successfully, but these errors were encountered: