Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor output formatting issues #77

Closed
ryleu opened this issue Jul 14, 2021 · 2 comments · Fixed by #78
Closed

Minor output formatting issues #77

ryleu opened this issue Jul 14, 2021 · 2 comments · Fixed by #78

Comments

@ryleu
Copy link
Contributor

ryleu commented Jul 14, 2021

These don't break things, but they annoy my linter:

  1. Keys are wrapped in " instead of ' @typescript-eslint/quotes
  2. Lines don't end with a semicolon @typescript-eslint/member-delimiter-style
  3. Lines end with spaces no-trailing-spaces

The linter I'm using is ESLint.

@rmp135
Copy link
Owner

rmp135 commented Jul 17, 2021

You can use the template config option to specify a bespoke template that will match your linter.

Copy the template.handlebars file, change what you need and point the template option at your new file.

@ryleu
Copy link
Contributor Author

ryleu commented Jul 18, 2021

I know, but the default IMO should follow TS best practices.

ryleu added a commit to ryleu/sql-ts that referenced this issue Jul 26, 2021
Made the default template output code that follows best practices. Resolves rmp135#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants