Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warnings #96

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Silence warnings #96

wants to merge 6 commits into from

Commits on Mar 20, 2023

  1. Silence warning about unused arguments 

    By naming the variable with the _ prefix the compiler knows it is intended to be unused.

> In browse-at-remote--format-region-url-as-gitiles:
> lib/browse-at-remote/browse-at-remote.el:456:103: Warning: Unused lexical argument `lineend'
    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bea3442 View commit details
    Browse the repository at this point in the history

  2. Ignore autoload files

    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5deed9c View commit details
    Browse the repository at this point in the history

  3. Silence warnings about docstring being wider than 80 characters 

    > lib/browse-at-remote/browse-at-remote.el:83:2: Warning: custom-declare-variable `browse-at-remote-preferred-remote-name' docstring wider than 80 characters
> lib/browse-at-remote/browse-at-remote.el:102:2: Warning: custom-declare-variable `browse-at-remote-add-line-number-if-no-region-selected' docstring wider than 80 characters
>
> In browse-at-remote--get-preferred-remote:
> lib/browse-at-remote/browse-at-remote.el:227:2: Warning: docstring wider than 80 characters
>
> In browse-at-remote--get-formatter:
> lib/browse-at-remote/browse-at-remote.el:274:2: Warning: docstring wider than 80 characters
    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a3a5b1b View commit details
    Browse the repository at this point in the history

  4. Replace SEQ-CONTAINS with SEQ-CONTAINS-P 

    > In browse-at-remote--format-region-url-as-pagure:
> lib/browse-at-remote/browse-at-remote.el:439:20: Warning: ‘seq-contains’ is an obsolete function (as of 27.1); use ‘seq-contains-p’ instead.
    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    87ba3d8 View commit details
    Browse the repository at this point in the history

  5. Silence warnings about functions not known to be defined 

    > In end of data:
> lib/browse-at-remote/browse-at-remote.el:544:42: Warning: the function ‘log-view-current-entry’ is not known to be defined.
> lib/browse-at-remote/browse-at-remote.el:514:34: Warning: the function ‘dired-current-directory’ is not known to be defined.
    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a66f142 View commit details
    Browse the repository at this point in the history

  6. Silence warning about usage of unescaped single qutoes 

    > lib/browse-at-remote/browse-at-remote.el:375:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
    @PuercoPop
    PuercoPop committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    9eeb7fe View commit details
    Browse the repository at this point in the history