build fails with forked version of dplyr

[dpastling]

build fails with forked version of dplyr jayhesselberth/dplyr

> devtools::install_github('jayhesselberth/dplyr')
> devtools::install_github('eddelbuettel/BH')
> devtools::install_github('jayhesselberth/valr')

...

g++ -std=c++0x \
    -I/vol4/home/astlingd/R/lib64/R/include \
    -DNDEBUG \
    -I../inst/include \
    -I/usr/local/include \
    -I"/vol4/home/astlingd/R/lib64/R/library/Rcpp/include" \
    -I"/vol4/home/astlingd/R/lib64/R/library/BH/include" \
    -I"/vol4/home/astlingd/R/lib64/R/library/dplyr/include" \
    -fpic  -g -O2 -c RcppExports.cpp -o RcppExports.o
In file included from ../inst/include/valr.h:6,
                 from RcppExports.cpp:4:
../inst/include/IntervalTree.h: In constructor ‘IntervalTree<T, K>::IntervalTree()’:
../inst/include/IntervalTree.h:63: error: ‘nullptr’ was not declared in this scope
../inst/include/IntervalTree.h: In copy constructor ‘IntervalTree<T, K>::IntervalTree(const IntervalTree<T, K>&)’:
../inst/include/IntervalTree.h:76: error: ‘nullptr’ was not declared in this scope
../inst/include/IntervalTree.h: In member function ‘IntervalTree<T, K>& IntervalTree<T, K>::operator=(const IntervalTree<T, K>&)’:
../inst/include/IntervalTree.h:87: error: ‘nullptr’ was not declared in this scope
../inst/include/IntervalTree.h: In constructor ‘IntervalTree<T, K>::IntervalTree(std::vector<Interval<T, K>, std::allocator<Interval<T, K> > >&, size_t, size_t, K, K, size_t)’:
../inst/include/IntervalTree.h:101: error: ‘nullptr’ was not declared in this scope
../inst/include/IntervalTree.h:140: error: parse error in template argument list
make: *** [RcppExports.o] Error 1
ERROR: compilation failed for package ‘valr’
* removing ‘/vol4/home/astlingd/R/lib64/R/library/valr’
Error: Command failed (1)


> devtools::session_info()
Session info -------------------------------------------------------------------
 setting  value                       
 version  R version 3.2.3 (2015-12-10)
 system   x86_64, linux-gnu           
 ui       X11                         
 language (EN)                        
 collate  en_US.UTF-8                 
 tz       <NA>                        
 date     2016-05-14                  

Packages -----------------------------------------------------------------------
 package  * version date       source        
 curl       0.9.7   2016-04-10 CRAN (R 3.2.3)
 devtools * 1.11.1  2016-04-21 CRAN (R 3.2.3)
 digest     0.6.9   2016-01-08 CRAN (R 3.2.2)
 git2r      0.14.0  2016-03-13 CRAN (R 3.2.3)
 httr       1.1.0   2016-01-28 CRAN (R 3.2.3)
 memoise    1.0.0   2016-01-29 CRAN (R 3.2.3)
 R6         2.1.2   2016-01-26 CRAN (R 3.2.3)
 withr      1.0.1   2016-02-04 CRAN (R 3.2.3)

[jayhesselberth]

The gcc on tesla is so, so old.

Can you try module load gcc and build with g++-5?

[dpastling]

Mmmm... still doesn't work. Here is what I tried:

• update R to version 3.3.0 (2016-05-03)
• tried install via devtools::install_github('jayhesselberth/valr') and got same error
• tried module load gcc
• build still fails

    $ which g++
    /vol1/software/modules-sw/gcc/5.1.0/bin/g++

\> devtools::install_github('jayhesselberth/valr')
Downloading GitHub repo jayhesselberth/valr@master
from URL https://api.github.com/repos/jayhesselberth/valr/zipball/master
Installing valr
Skipping install for github remote, the SHA1 (9ebfca76) has not changed since last install.
  Use `force = TRUE` to force installation
Skipping 2 packages ahead of CRAN: dplyr, tibble
'/vol4/home/astlingd/R/lib64/R/bin/R' --no-site-file --no-environ --no-save  \
  --no-restore --quiet CMD INSTALL  \
  '/tmp/RtmpmwfQ4W/devtools69a4fee91a6/jayhesselberth-valr-4e430f0'  \
  --library='/vol4/home/astlingd/R/lib64/R/library' --install-tests 

* installing *source* package ‘valr’ ...
** libs
g++ -std=c++0x -I/vol4/home/astlingd/R/lib64/R/include -DNDEBUG -I../inst/include -I/usr/local/include -I"/vol4/home/astlingd/R/lib64/R/library/Rcpp/include" -I"/vol4/home/astlingd/R/lib64/R/library/BH/include" -I"/vol4/home/astlingd/R/lib64/R/library/dplyr/include"   -fpic  -g -O2 -c RcppExports.cpp -o RcppExports.o
In file included from ../inst/include/valr.h:6:0,
                 from RcppExports.cpp:4:
../inst/include/IntervalTree.h: In constructor ‘IntervalTree<T, K>::IntervalTree(IntervalTree<T, K>::intervalVector&, std::size_t, std::size_t, K, K, std::size_t’:
../inst/include/IntervalTree.h:140:37: error: use of ‘this’ in a constant expression
                 if (interval.stop < center) {
                                     ^
../inst/include/IntervalTree.h:140:30: error: parse error in template argument list
                 if (interval.stop < center) {
                              ^
make: *** [RcppExports.o] Error 1
ERROR: compilation failed for package ‘valr’
* removing ‘/vol4/home/astlingd/R/lib64/R/library/valr’
Error: Command failed (1)

> devtools::session_info()
Session info -------------------------------------------------------------------
 setting  value                       
 version  R version 3.3.0 (2016-05-03)
 system   x86_64, linux-gnu           
 ui       X11                         
 language (EN)                        
 collate  en_US.UTF-8                 
 tz       <NA>                        
 date     2016-05-15                  

Packages -----------------------------------------------------------------------
 package  * version date       source        
 curl       0.9.7   2016-04-10 CRAN (R 3.2.3)
 devtools   1.11.1  2016-04-21 CRAN (R 3.2.3)
 digest     0.6.9   2016-01-08 CRAN (R 3.2.2)
 git2r      0.14.0  2016-03-13 CRAN (R 3.2.3)
 httr       1.1.0   2016-01-28 CRAN (R 3.2.3)
 memoise    1.0.0   2016-01-29 CRAN (R 3.2.3)
 R6         2.1.2   2016-01-26 CRAN (R 3.2.3)
 withr      1.0.1   2016-02-04 CRAN (R 3.2.3)

[jayhesselberth]

valr compiles cleanly with clang++, so OS X may be the only option until I get some time to appease the g++ compiler.

[jayhesselberth]

valr should be installable on Linux with clang++ >= 3.7

See build log at https://travis-ci.org/jayhesselberth/valr/jobs/148445783