Fix PHP 8.4 deprecations

[novikoff-vvs]

Q	A
Bugfix?	✔️
Issues	issues/39
Docs PR	N/A

This PR resolves PHP 8.4 deprecation warnings related to implicitly nullable parameters.
It also applies spiral/code-style fixer for consistent formatting across affected classes.

Summary by CodeRabbit

• Refactor
  • Improved type clarity in several constructors by explicitly allowing nullable types.
  • Added trailing commas for consistency in parameter lists and method calls.
• Style
  • Minor formatting adjustments to exception messages for improved readability.

[coderabbitai]

Walkthrough

This update introduces consistent use of nullable type hints in several constructor signatures and adds trailing commas to parameter lists and method calls across multiple files. The changes are syntactical and do not affect logic or control flow, focusing on type clarity and code formatting improvements.

Changes

File(s)	Change Summary
src/Environment/Native.php	Added trailing comma in constructor parameter list for $values property.
src/Exception/UnsupportedVersionException.php	Added trailing comma after the last constructor parameter $requested.
src/Version/Comparator.php	Changed constructor parameter to nullable ?VersionParser; added trailing commas in method calls.
src/Version/Installed.php	Made constructor parameters nullable for ProcessInterface and EnvironmentInterface; added trailing commas.
src/Version/Required.php	Made constructor parameter nullable for PackageInterface.
src/VersionChecker.php	Made constructor parameters nullable for interfaces; added trailing commas and fixed minor syntax in method calls.

Poem

In fields of code, the commas hop,
Making type hints clear on every stop.
Nullable now, the classes align,
Constructors tidy, formatting fine.
With syntax neat and warnings few,
This bunny cheers the code anew!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 03ae291 and 7c2c033.

📒 Files selected for processing (6)

• src/Environment/Native.php (1 hunks)
• src/Exception/UnsupportedVersionException.php (1 hunks)
• src/Version/Comparator.php (4 hunks)
• src/Version/Installed.php (2 hunks)
• src/Version/Required.php (1 hunks)
• src/VersionChecker.php (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Version/Required.php (3)

src/Version/Installed.php (1)

• __construct (29-36)

src/VersionChecker.php (1)

• __construct (23-31)

src/Version/Comparator.php (1)

• __construct (14-17)

🔇 Additional comments (13)

src/Exception/UnsupportedVersionException.php (1)

17-17: Code style improvement with trailing comma

Adding a trailing comma after the last parameter in the constructor follows modern PHP coding standards and aligns with the spiral/code-style guide. This makes future parameter additions cleaner and results in better git diffs.

src/Environment/Native.php (1)

10-10: Code style improvement with trailing comma

Adding a trailing comma after the default value in the constructor parameter declaration is consistent with modern PHP coding standards and the spiral/code-style guide. This improves readability and simplifies future modifications.

src/Version/Comparator.php (4)

14-14: Fixed PHP 8.4 deprecation with explicit nullable type

The change from VersionParser $parser = null to ?VersionParser $parser = null correctly addresses the PHP 8.4 deprecation warning for implicitly nullable parameters. This makes the parameter's nullability explicit in the type declaration rather than just in the default value.

---

27-28: Code style improvement with trailing comma

Adding the trailing comma after the last parameter in the method call to SemverComparator::greaterThanOrEqualTo() follows the spiral/code-style guidelines and modern PHP coding standards.

---

39-40: Code style improvement with trailing comma

Adding the trailing comma after the last parameter in the method call to SemverComparator::lessThanOrEqualTo() maintains consistency with the code style improvements throughout this PR.

---

51-52: Code style improvement with trailing comma

Adding the trailing comma after the last parameter in the method call to SemverComparator::equalTo() completes the consistent application of the spiral/code-style standard across all similar method calls in this class.

src/Version/Required.php (1)

22-22: Fixed PHP 8.4 deprecation with explicit nullable type

Changing from PackageInterface $package = null to ?PackageInterface $package = null properly addresses the PHP 8.4 deprecation for implicitly nullable parameters. This change maintains the same behavior while making the type nullability explicit, which aligns with similar changes in other classes like Installed, Comparator, and VersionChecker.

src/Version/Installed.php (2)

30-32: Introduce explicit nullable type hints in constructor
Adding ?ProcessInterface and ?EnvironmentInterface parameters resolves PHP 8.4 deprecation warnings for implicitly nullable types. The trailing comma in the parameter list also aligns with the applied code‐style rules.

---

84-90: Add trailing comma in sprintf call arguments
The trailing comma after self::class standardizes the argument formatting in the sprintf call, matching the code‐style fixer’s conventions.

src/VersionChecker.php (4)

24-26: Allow nullable injected dependencies in constructor
Making the InstalledInterface, RequiredInterface, and ComparatorInterface parameters nullable and supplying defaults maintains backward compatibility while fixing PHP 8.4 deprecation notices. The trailing comma enhances parameter list consistency.

---

47-51: Normalize trailing comma in exception message formatting
The added comma after the message string in RequiredVersionException’s sprintf call ensures consistent argument list styling.

---

74-80: Normalize trailing comma in UnsupportedVersionException (lessThan)
Adding the comma after $version in the exception instantiation aligns with the project’s code style rules for multi‐line argument lists.

---

94-98: Normalize trailing comma in UnsupportedVersionException (equal)
The trailing comma after $version in sprintf arguments is stylistically consistent with the rest of the changes applied by spiral/code-style.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.