-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working well in VSCode January 2022 (version 1.64) #252
Comments
Following an update to 1.64 on Windows, the extension has no effect for me until I swap to a different colour scheme and back. Nothing particularly interesting shows up in the developer console, except that when I switch back to Synthwave '84 I get a console message "NEON DREAMS initalised!". If I reload the editor it has to be done again. The usual run as Administrator, enable Neon Dreams, restart process does not do the permanent job it once did. It looks like whatever change the extension makes is no longer persistent due to VS Code changes. Here's the release notes for the update: https://code.visualstudio.com/updates/v1_64 None of the changes look relevant to me, though I haven't dug into the code of this extension to know how it works besides that it changes some core CSS files. Rolling back to 1.63.2 resolves the issue, the extension certainly works as intended on that version. |
I have the same issue, today my VSCode updated to Others theme as Fluoromachine are working the Neon glow, so I don't know if there is only a problem with the vscode update or something else.. |
Chiming in here, I get the same behavior as @isosphere |
It looks like whatever this extension does to load the custom CSS isn't working correctly.
Mac "vscode_custom_css.imports": [
"file:///Users/{YOUR_USER_NAME}/.vscode/extensions/robbowen.synthwave-vscode-0.1.10/synthwave84.css"
] Windows "vscode_custom_css.imports": [
"file:///C:/Users/{YOUR_USER_NAME}/.vscode/extensions/robbowen.synthwave-vscode-0.1.10/synthwave84.css"
]
Current VSCode running on Mac
|
I can confirm that this solution works for me on Windows, with the caveat that the "Reload Custom CSS and JS" step must be run as Administrator. Additional caveat: I adjusted my glow value using |
I tried changing that setting, and it doesn't do anything for me either. In the css file for the extension, I believe its the last 2 HEX color digits in the text-shadow: 0 0 2px #001716, 0 0 3px #03edf975, 0 0 5px #03edf975, 0 0 8px #03edf975; To: text-shadow: 0 0 2px #001716, 0 0 3px #03edf999, 0 0 5px #03edf999, 0 0 8px #03edf999; You may have to re run the custom css loader command afterwards. |
It worked for me on linux Fedora 35 I need to run this before: sudo chown -R (whoami) /usr/share/code and change: "vscode_custom_css.imports": [
"file:///home/{YOUR_USER_NAME}/.vscode/extensions/robbowen.synthwave-vscode-0.1.10/synthwave84.css"
] |
It does seem like the code for enabling the glow has stopped working as of the latest version of VS code, so I will look to get it fixed as soon as possible. Just an FYI - this extension hasn't used the Custom CSS and JS plugin for a long time now, so enabling it as a workaround might cause compatibility issues once I have been able to fix the core theme. |
Thanks for looking into this @robb0wen! I think people's desire to find a workaround is a testament to how much we love this theme! I know personally had been hunting for the perfect theme for years. Once I found this one, I was able to stop searching! 🤩 Thanks again for creating/supporting this amazing extension! |
I enabled the "Custom CSS and JS" extension, followed @novym's recommendations, and then disabled it. It fixed it for me and I no longer had to reactivate the glow at every start. |
I've just published a new version of the extension (v0.1.11) to the VS code marketplace. This should fix the issue so that the glow loads on bootup. If you have used the Custom CSS and JS workaround, disable that in case this causes further issues.
Big thanks to @isosphere for suggesting swapping to another theme caused the glow to appear. That was a big help in identifying the cause of the failure. Cheers! |
You are awesome. Thank you for your fast response 🥳 |
Update is working for me! I am delighted that I could save you some time, thank you for your swift response. |
Still having trouble getting the glow to appear on Arch (Garuda) Linux. Weirdly enough, the Custom CSS and JS loader extension doesn't appear on the marketplace, and installing it via the command line doesn't seem to work either. Hmm. |
Hello! Just for confirm that with the update |
I second @jruizsulime, it's working perfect again! That was a terrifying 72 hours... 😅 |
Glad to see this is working again. @projectintel-anon the latest version of the theme doesn't need the Custom CSS and JS loader plugin to enable the glow. Have you got v0.1.11 of Synthwave '84 installed? did the glow work for you previously? |
@robb0wen So after digging a little deeper, I found out that I could not get the glow to work on VS Code that was installed via Snap or "Code OSS" (default on pacman). The glow only works for me on the chaotic-aur version or if I build it directly from git. Nonetheless I got it working! |
need to be reapplied for the glow to function, even after activating it manually with ctrl+shift+p
The text was updated successfully, but these errors were encountered: