Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw the commits in project https://github.com/fredokun/cl-jupyter adding message encryption (see fredokun/cl-jupyter@4141a0a and fredokun/cl-jupyter@510aea1) and since i needed it for the maxima-jupyter kernel, i tried to apply the same changes in this project. Also added the
key
indefun send-input-request
.I was able to build the core image and put it to work with the current stable version of jupyterhub 0.2.0.
However, i'm a programmer but not a LISP or Maxima programmer (as a matter of fact, i do not know a single line of LISP...). So i ask you to verify the changes and see if they make sense to you.
I still have a problem dealing with inputs like "integrate (u^k, u)" (without the single quote operator); i think it's related to questions from Maxima to the user, via asksign. I'm sure i'm missing something... Please give me some feedback about this.
Thank you for the project.