Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message encryption. #1

Merged
merged 2 commits into from
Oct 12, 2015
Merged

Conversation

dsoares
Copy link
Contributor

@dsoares dsoares commented Oct 12, 2015

Hi,

I saw the commits in project https://github.com/fredokun/cl-jupyter adding message encryption (see fredokun/cl-jupyter@4141a0a and fredokun/cl-jupyter@510aea1) and since i needed it for the maxima-jupyter kernel, i tried to apply the same changes in this project. Also added the key in defun send-input-request.
I was able to build the core image and put it to work with the current stable version of jupyterhub 0.2.0.

However, i'm a programmer but not a LISP or Maxima programmer (as a matter of fact, i do not know a single line of LISP...). So i ask you to verify the changes and see if they make sense to you.

I still have a problem dealing with inputs like "integrate (u^k, u)" (without the single quote operator); i think it's related to questions from Maxima to the user, via asksign. I'm sure i'm missing something... Please give me some feedback about this.

Thank you for the project.

robert-dodier added a commit that referenced this pull request Oct 12, 2015
@robert-dodier robert-dodier merged commit aeb1dbb into robert-dodier:master Oct 12, 2015
@robert-dodier
Copy link
Owner

Hi, I've merged the pull request. I haven't tried the new code yet but I will soon. About questions caused by integrate(u^k, u) and other examples, these are supposed to be handled by input_request/input_reply in Jupyter -- the kernel discovers that it needs user input, sends a request to the front end, front end solicits user input, which it sends back to kernel. It was working OK when I was using the notebook interface, perhaps you can try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants