-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friday lab #10
Open
robert-hatfield
wants to merge
18
commits into
master
Choose a base branch
from
friday-lab
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Friday lab #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also cleaned up commented-out code & print statements used while debugging.
I'll need to adjust this to display a user-friendly name for each filter.
I made lots of little UX tweaks (alternate animation durations, adjusted logic of how & when the preview collection view may be dismissed, disabled filter button if user has not loaded an image) that should have been committed separately. The filter actions are no longer on an action sheet, but since the assignment called for a refactor, actions when tapping on the main image view should now be more modular. With only 3 possible actions, this only saved about 2 lines of code.
Also added more marks for extensions
This keeps user-friendly names and CoreImage names together.
Appending to history after each filter is applied to the primary image. Undo / reset not yet available.
Undo button isn't operational yet; I'll set it to appear only when one or more filters have been applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Stories (MVP)
Technical Requirements
friday-cleanup
with regular commit history