Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support push to go slices #460

Merged
merged 1 commit into from
Nov 27, 2022
Merged

feat: support push to go slices #460

merged 1 commit into from
Nov 27, 2022

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Nov 27, 2022

Add support for direct use of push to go slices without converting to array using .slice().

Fixes #357

Also:

  • Add classGoSlice and use it, to make it clear the type when debugging.

Add support for direct use of push to go slices without converting to
array using .slice().

Fixes #357

Also:
* Add classGoSlice and use it, to make it clear the type when debugging.
@stevenh stevenh merged commit c4b9430 into master Nov 27, 2022
@stevenh stevenh deleted the feat/slice-push branch November 27, 2022 23:09
sg3des pushed a commit to sg3des/otto that referenced this pull request Jul 17, 2023
Add support for direct use of push to go slices without converting to
array using .slice().

Fixes robertkrimen#357

Also:
* Add classGoSlice and use it, to make it clear the type when debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot push into array that was set with vm.Set()
1 participant