chore: remove perl, make and local docs. #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependencies on perl and make. inline.pl is not replaced by tools/gen-jscore and token/tokenfmt is replaced by tools/gen-tokens which are both golang text/template utilities. gen-jscore uses property ordering that matches chromes output ordering adding missing properties to the Error types. Local generated documentation has now been removed as https://pkg.go.dev/ is more feature rich. The use of make has been removed as the functionality is now replicated by standard golang tools go test ./... and go generate ./... as well as integrated into github actions.
Remove perl script tokenfmt. Restore non generated underscore README.
stevenh
added a commit
that referenced
this pull request
Dec 5, 2022
Add inline tests missed in PR #476.
stevenh
added a commit
that referenced
this pull request
Dec 5, 2022
Add inline tests missed in PR #476.
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Remove the dependencies on perl and make. inline.pl is replaced by tools/gen-jscore and token/tokenfmt is replaced by tools/gen-tokens which are both golang text/template utilities. gen-jscore uses property ordering that matches chromes output ordering adding missing properties to the Error types. Local generated documentation have been removed as https://pkg.go.dev/ is more feature rich. The use of make has been removed as the functionality is now replicated by standard golang tools go test ./... and go generate ./... as well as integrated into github actions.
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Add inline tests missed in PR robertkrimen#476.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependencies on perl and make.
inline.plis replaced bytools/gen-jscoreandtoken/tokenfmtis replaced bytools/gen-tokenswhich are both golang text/template utilities.gen-jscoreuses property ordering that matches chromes output ordering adding missing properties to the Error types.Local generated documentation have been removed as https://pkg.go.dev/ is more feature rich.
The use of make has been removed as the functionality is now replicated by standard golang tools
go test ./...andgo generate ./...as well as integrated into github actions.