Skip to content

Add failing test case for exists function. #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2016
Merged

Add failing test case for exists function. #67

merged 4 commits into from
Oct 30, 2016

Conversation

robertzk
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.788% when pulling 8e924b1 on implement_exists_method into 916b2de on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 87.844% when pulling 8e924b1 on implement_exists_method into 916b2de on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 87.844% when pulling 8e924b1 on implement_exists_method into 916b2de on master.

peterhurford
peterhurford reviewed Oct 29, 2016
View reviewed changes
tests/testthat/test-tracked_environment.R
expect_false(exists("w", env = x))
expect_true(exists("z", env = x))
expect_false(exists("z", env = x, inherits = FALSE))
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👍

@robertzk robertzk merged commit de0edd7 into master Oct 30, 2016
@robertzk robertzk deleted the implement_exists_method branch October 30, 2016 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhurford peterhurford peterhurford left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertzk @coveralls @peterhurford