Bugfix - Target name overriding #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message encoder's target name to allow for client overriding
|
👍 LGTM |
|
👍 |
jstruzik
added a commit
that referenced
this pull request
Nov 16, 2015
Bugfix - Target name overriding
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the fall-back order of the authentication message encoder's target name acquisition to allow for client overriding.
Or in other words, code that called
NtlmV1AuthenticateMessageEncoder::encode()and/orNtlmV2AuthenticateMessageEncoder:encode()were unable to present a manual NT-domain/target-name, as the implementations were always taking the server's challenge message target-name as truth.The reliance on the server challenge makes sense in a lot of cases, and still does if a user calls these methods with empty values, however it disallowed any sort of manual entry which is necessary in some multi-tenant service authentication environments.