Skip to content

Conversation

otopba
Copy link
Contributor

@otopba otopba commented Jul 26, 2017

non-breaking space symbol is not allowed in url

@robinst
Copy link
Owner

robinst commented Jul 28, 2017

Hey, thanks for the PR!

Do you have a reference for why the U+A0 NO-BREAK SPACE is not allowed in URLs? I looked at RFC 3987 and it explicitly allows the character (search for %xA0). Having said that, I think it makes sense to exclude whitespace characters in this library. Maybe we should list some others as well.

@otopba
Copy link
Contributor Author

otopba commented Jul 28, 2017

Hi, @robinst !

image
link

There can not be any of the types of spaces in the url. This is not allowed. RFC 3987
is indicated that the use of this symbol is allowed in ucschar. I do not know what is ucschar = /

Also, this link can be useful:
wikipedia

@robinst robinst merged commit ff07502 into robinst:master Aug 31, 2017
@robinst
Copy link
Owner

robinst commented Aug 31, 2017

Thanks, merged. I decided I'll add some other Unicode whitespace characters as well, see the list here: https://en.wikipedia.org/wiki/Whitespace_character#Unicode

@robinst
Copy link
Owner

robinst commented Aug 31, 2017

Released in 0.7.0: https://github.com/robinst/autolink-java/blob/master/CHANGELOG.md#070---2017-08-31

@otopba
Copy link
Contributor Author

otopba commented Aug 31, 2017

@robinst Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants