Treat more special characters as trailing delimiters (#3) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `;` is now treated the same as `,` and `:` * `<` and `>` now also need to match, same as other brackets * `/` can still be within or at the end of an URL, but if it's within a group of other delimiters, it behaves as a delimiter Together, these new rules result in `">`, `"/>` and `");` to be excluded at the end of links, while hopefully not messing with the overall heuristics too much.
robinst
added a commit
that referenced
this pull request
Feb 9, 2016
Treat more special characters as trailing delimiters (#3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;is now treated the same as,and:<and>now also need to match, same as other brackets/can still be within or at the end of an URL, but if it's within agroup of other delimiters, it behaves as a delimiter
Together, these new rules result in
">,"/>and");to be excludedat the end of links, while hopefully not messing with the overall
heuristics too much.