Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler_msgs: revise Request.status labels #60

Closed
jack-oquin opened this issue Dec 17, 2013 · 8 comments
Closed

scheduler_msgs: revise Request.status labels #60

jack-oquin opened this issue Dec 17, 2013 · 8 comments

Comments

@jack-oquin
Copy link
Contributor

This issue is a forum for discussing scheduler request status updates. The proposed changes will be made in two steps:

  1. define new labels; deprecate some old ones
  2. remove deprecated labels once users have updated

The current proposal is:

  • rename RELEASED status to CANCELED.
  • rename RELEASING status to CANCELING.
  • eliminate ABORTED status: use CANCELED instead.
  • eliminate PREEMPTED status: use CANCELED instead.
  • eliminate REJECTED status: use CANCELED instead.

With this proposal, CANCELED becomes the only terminal state. Once acknowledged, the canceled request will be deleted.

As best I can tell, the abort() and reject() events can handled via preempt(), simplifying the state transitions considerably.
@jack-oquin jack-oquin mentioned this issue Dec 17, 2013
Closed
jack-oquin added a commit to utexas-bwi/rocon_scheduler_requests that referenced this issue Dec 17, 2013
@jack-oquin
fix some state transition issues (#18, robotics-in-concert/rocon_msgs#60
e0145dd 
)
jack-oquin added a commit to utexas-bwi/rocon_scheduler_requests that referenced this issue Dec 18, 2013
@jack-oquin
document state transition graph (#18, robotics-in-concert/rocon_msgs#60)
24378a6
@jack-oquin
Copy link
Contributor Author

New transition graph documentation:

@stonier
Copy link
Member

stonier commented Dec 18, 2013

Looks good Jack. I actually don't have anything to discuss here :)

@jack-oquin
Copy link
Contributor Author

Sure.

I am not yet ready to commit this change, but wanted to put the ideas in writing where they will be handy when the time is right.

Maybe something more will come up after further development. If it does, let's add it here.

jack-oquin added a commit to utexas-bwi/rocon_scheduler_requests that referenced this issue Dec 20, 2013
@jack-oquin
use new Request status labels (#18, robotics-in-concert/rocon_msgs#60)
86df94b 
remains backwards compatible with earlier scheduler_msgs/Request
uses CANCEL states in place of RELEASED, RELEASING
avoids deprecated labels
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 20, 2013
@jack-oquin
scheduler_msgs: Request label revisions (robotics-in-concert#60)
5abd825
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 20, 2013
@jack-oquin
scheduler_msgs: update Request message documentation (robotics-in-con…
a9d1262 
…cert#60)
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 20, 2013
@jack-oquin
scheduler_msgs: better Request message priority labels (robotics-in-c…
3b0b0ff 
…oncert#60)
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 20, 2013
@jack-oquin
scheduler_msgs: extend range of Request priority labels (robotics-in-…
3465d31 
…concert#60)
@jack-oquin jack-oquin mentioned this issue Dec 20, 2013
Closed
@jack-oquin
Copy link
Contributor Author

I closed pull request #64 so we can consider additional changes.

I want to only make one update for this go-around.

jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 21, 2013
@jack-oquin
more Request message updates (robotics-in-concert#60)
af874de 
rename terminal status label CLOSED
add reason field to supplement status
@jack-oquin
Copy link
Contributor Author

The previous commit renames the terminal status to CLOSED.

It also adds a reason field to supplement the request status, which allows the scheduler to tell the requester why a request was queued, preempted or closed. I want to add that now, because we really can't start using it until it has been released.

jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 22, 2013
@jack-oquin
change history update (robotics-in-concert#60)
34fc4f0
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 22, 2013
@jack-oquin
reformat change history for github markdown (robotics-in-concert#60)
e92d490
@jack-oquin jack-oquin mentioned this issue Dec 23, 2013
Closed
5 tasks
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 27, 2013
@jack-oquin
scheduler_msgs: remove deprecated labels (robotics-in-concert#60)
b235616
jack-oquin added a commit to jack-oquin/rocon_msgs that referenced this issue Dec 28, 2013
@jack-oquin
scheduler_msgs: backport Request revisions to Hydro (robotics-in-conc…
c061397 
…ert#60)
stonier added a commit that referenced this issue Dec 29, 2013
@stonier
Merge pull request #65 from jack-oquin/hydro-devel
25abc45 
scheduler_msgs: Request message revisions (#60)
stonier added a commit that referenced this issue Dec 29, 2013
@stonier
Merge pull request #67 from jack-oquin/hydro
8316eae 
scheduler_msgs: backport Request revisions to Hydro (#60)
@jack-oquin
Copy link
Contributor Author

I tried to take out the backwards compatibility logic in my code (utexas-bwi/rocon_scheduler_requests#21). The pre-release tests build dependencies from source, so they work.

But the devel tests install binary dependency packages, so they fail on the build farm. So, I need a new hydro branch release to avoid having to put back the compatibility logic.

Would that be OK?

@jack-oquin jack-oquin reopened this Jan 10, 2014
@stonier
Copy link
Member

stonier commented Jan 14, 2014

Would that be OK?

Sure. Just send a pull request and I'll bump a new release anytime. I have scripts which mean it takes all of 5mins for me to do.

@jack-oquin
Copy link
Contributor Author

The updates are already merged from #67, I just need a Hydro release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stonier @jack-oquin