Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMake targets #11

Closed
PeterBowman opened this issue Jun 13, 2018 · 2 comments
Closed

Use CMake targets #11

PeterBowman opened this issue Jun 13, 2018 · 2 comments
Assignees
@PeterBowman

Comments

@PeterBowman
Copy link
Member

That is, export a ROBOTICSLAB::ColorDebug target (proposed name) instead of (or additionally to?) the COLOR_DEBUG_INCLUDE_DIRS variable. Requires CMake 2.8.11.
@PeterBowman
Copy link
Member Author

PeterBowman commented Jun 15, 2018 •
edited
Loading

Org-wide task (already fulfilled): roboticslab-uc3m/questions-and-answers#44.

@PeterBowman PeterBowman mentioned this issue Jun 15, 2018
Closed
@PeterBowman PeterBowman self-assigned this Jun 15, 2018
@PeterBowman
Copy link
Member Author

PeterBowman commented Jun 15, 2018 •
edited
Loading

Done at 7208215. Minimum CMake required version has been bumped to 2.8.12 (support for ALIAS targets). BTW this is a breaking change that enforces YCM usage as a hard dependency (roboticslab-uc3m/questions-and-answers#55 (comment)). The positive side is a cleaner and easier to maintain CMake code that will spare us some past headaches (see #6 and #8).

@PeterBowman PeterBowman mentioned this issue Jun 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterBowman PeterBowman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeterBowman