Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need autoformatters #25

Closed
3 tasks done
jwnimmer-tri opened this issue May 8, 2023 · 1 comment
Closed
3 tasks done

Need autoformatters #25

jwnimmer-tri opened this issue May 8, 2023 · 1 comment
Assignees
@jwnimmer-tri
Labels
enhancement New feature or request

Comments

@jwnimmer-tri
Copy link
Contributor

jwnimmer-tri commented May 8, 2023 •
edited
Loading

Accepting contributions from the community will be easier if we don't need to deal with code formatting.

  • We should adopt a one-true-style tool (e.g., pyblack) and integrate it as a bazel test //... linter.
  • We should integrate isort.
  • We should integrate buildifier.
@jwnimmer-tri jwnimmer-tri self-assigned this May 8, 2023
@jwnimmer-tri jwnimmer-tri mentioned this issue May 11, 2023
Merged
This was referenced May 23, 2023
Merged
Merged
@jwnimmer-tri jwnimmer-tri changed the title Need an autoformatter Need autoformatters May 23, 2023
@jwnimmer-tri jwnimmer-tri mentioned this issue May 23, 2023
Merged
@jwnimmer-tri jwnimmer-tri added the enhancement New feature or request label May 23, 2023
@jwnimmer-tri
Copy link
Contributor Author

We have Python and Bazel covered now, with nice linter wrappers. I think that's good enough.

If we find more specific improvements, we can open new issues for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwnimmer-tri jwnimmer-tri

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwnimmer-tri