Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[faceExpression] added talking mouth #89

Merged
merged 1 commit into from
May 4, 2018
Merged

[faceExpression] added talking mouth #89

merged 1 commit into from
May 4, 2018

Conversation

pattacini
Copy link
Member

@pattacini pattacini commented May 4, 2018 •
edited
Loading

This PR introduces the so-called talking mouth modality. See the video below (wait until the GIF gets entirely loaded to play it smoothly).

How-to guide to enable/disable talking

$ yarp rpc /faceExpressionImage/rpc
>> [tstart]
>> [tstop]

These commands resemble somehow [astart] & [astop] that are used to start/stop listening audio sources.

cc @vtikha

ezgif com-resize

@pattacini pattacini self-assigned this May 4, 2018
@pattacini pattacini requested a review from barbalberto May 4, 2018 09:14
@pattacini pattacini mentioned this pull request May 4, 2018
Closed
barbalberto
barbalberto approved these changes May 4, 2018
View reviewed changes
Copy link

@barbalberto barbalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@barbalberto barbalberto merged commit 5b170a1 into devel May 4, 2018
@pattacini pattacini deleted the feat/talking-face branch May 4, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbalberto barbalberto barbalberto approved these changes

Assignees

@pattacini pattacini

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattacini @barbalberto