Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linkattacher initialization #497

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Add linkattacher initialization #497

merged 2 commits into from
Jul 3, 2020

Conversation

lrapetti
Copy link
Member

@lrapetti lrapetti commented Jul 3, 2020

This PR adds the possibility to apply a desired set of linkattacher command at the startup.

The usage documentation can be found in plugins/linkattacher/README.md#startup-configuration.

@lrapetti lrapetti force-pushed the add-linkattacher-initialization branch from 0d93ea7 to d7cc800 Compare July 3, 2020 09:42
@lrapetti lrapetti force-pushed the add-linkattacher-initialization branch from d7cc800 to ef9c911 Compare July 3, 2020 09:43
@lrapetti
Copy link
Member Author

lrapetti commented Jul 3, 2020

MacOS CI is failing for Gazebo versions 9/10 as documented in robotology/robotology-superbuild#420.

The problem seems to be already fixed in master (see https://github.com/robotology/gazebo-yarp-plugins/blob/master/.github/workflows/ci.yml#L18-L34).

@traversaro what is the policy, should I address master directly with the PR? Or merge master to devel?

@traversaro
Copy link
Member

@traversaro what is the policy, should I address master directly with the PR? Or merge master to devel?

I should have merged master in devel, I simply forgot to do it. Let's merge this PR if the CI is working in the other platforms, and then I will merge master in devel.

@traversaro
Copy link
Member

Can I Squash and Merge or you want to cleanup the commits?

@lrapetti
Copy link
Member Author

lrapetti commented Jul 3, 2020

Can I Squash and Merge or you want to cleanup the commits?

sure, you can proceed squashing

@traversaro traversaro merged commit ec850ad into robotology:devel Jul 3, 2020
@traversaro
Copy link
Member

Thank @lrapetti !

@lrapetti lrapetti deleted the add-linkattacher-initialization branch July 3, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@yeshasvitirupachuri yeshasvitirupachuri yeshasvitirupachuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lrapetti @traversaro @yeshasvitirupachuri