Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for getDevicesAsPolyDriverList method used by libYARP_robotinterface #544

Merged
merged 6 commits into from
Mar 3, 2021

Conversation

traversaro
Copy link
Member

In particular, ensure that also devices registered by sensor plugins are correctly exposed to libYARP_robotinterface.

Fix #543 .

cc @drdanz @randaz81

In particular, ensure that also devices registered by sensor plugins are correctly exposed to libYARP_robotinterface
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with ROS and ROS2 nws

@traversaro
Copy link
Member Author

Actually default it just happens to be the world name, we should get the world name and use that instead of hardcoding default::, looking into it.

@traversaro
Copy link
Member Author

@drdanz I updated the code to be generic w.r.t. to world name, could you check if this is still working for you? Thanks!

Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again, it works, thanks

@traversaro
Copy link
Member Author

Thanks @drdanz !

@traversaro traversaro merged commit 40ef333 into master Mar 3, 2021
@traversaro traversaro deleted the fix-543-error branch March 3, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libYARP_robotinterface not working correctly with sensor plugins
2 participants