Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some models generate reusable functions #53

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Made some models generate reusable functions #53

merged 1 commit into from
Jun 27, 2023

Conversation

pattacini
Copy link
Member

This PR makes the control and estimation models generate reusable functions.
To this end, I had to modify the following options:

  • Code Generation > Interface > Code interface packaging: Reusable function1
    • Code Generation > Interface > Pass root-level I/O as: Structure reference
  • Code Generation > Identifiers > Maximum identifier length: 602
  • Model Referencing > Total number of instances allowed per top model: Multiple

Warning
This PR needs to be first tested on the device.

Footnotes

  1. When the model contains a macro subsystem, I had also to set the same option in the Code Generation tab of the Block Parameter.

  2. I wouldn't expect an impact on our FW compiler as modern toolchains are perfectly capable of dealing with long identifiers. To be checked anyway.

@pattacini pattacini self-assigned this Jun 23, 2023
@pattacini pattacini added team-fix Activity performed by Team FIX domain-modeling Pertains to model-based design labels Jun 23, 2023
@pattacini pattacini linked an issue Jun 23, 2023 that may be closed by this pull request
@pattacini pattacini added the type-board-amcbldc Relevant to the AMCBLDC development label Jun 23, 2023
@pattacini pattacini requested a review from mfussi66 June 23, 2023 09:15
@mfussi66
Copy link
Member

Just tested on the Wrist Lego setup, everything seems work just fine 👍
I tested both the current control mode and velocity, with no problems.

@pattacini pattacini marked this pull request as ready for review June 27, 2023 09:41
@pattacini
Copy link
Member Author

Thanks heaps @mfussi66!
Merging then.

@pattacini pattacini changed the base branch from master to devel June 27, 2023 09:42
@pattacini pattacini merged commit 2e2670b into devel Jun 27, 2023
@pattacini pattacini deleted the feat/50 branch June 27, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-modeling Pertains to model-based design team-fix Activity performed by Team FIX type-board-amcbldc Relevant to the AMCBLDC development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore ways to support code reusability
2 participants