Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity checks for iCub3 models #51

Closed
traversaro opened this issue Oct 17, 2020 · 2 comments
Closed

Add sanity checks for iCub3 models #51

traversaro opened this issue Oct 17, 2020 · 2 comments
Assignees
Labels

Comments

@traversaro
Copy link
Member

To avoid strange regressions, we have some sanity checks for the iCub 2.* models in https://github.com/robotology/icub-model-generator/blob/master/tests/CMakeLists.txt#L25 . It probably could make sense to have similar checks for iCub 3 models, to avoid regressions such as the one described in #41 (comment) .

@Nicogene Nicogene self-assigned this Oct 21, 2020
@Nicogene
Copy link
Member

This is partially fixed by robotology/icub-models-generator#149.

Using the sanity checks emerged the difference between icub2 and icub3 for what concerns the orientation of ft sensors

@traversaro
Copy link
Member Author

Fixed by robotology/icub-models-generator#149 . I guess that if the need for new tests arise, they can be added to the test suite, no need for a separate issue tracking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants