YARP shared library is linked against static system libSDL.a instead of libSDL.so #191

VenusPasandi · 2019-04-01T14:05:45Z

I tried to install the robotology-superbuild and I got the following error when I do make,

[ 63%] Built target yarp_test_grabber
[ 63%] Linking CXX shared module ../../../lib/yarp/yarp_SDLJoypad.so
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libSDL.a(SDL.o): relocation R_X86_64_PC32 against symbol `SDL_InitSubSystem' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
src/devices/SDLJoypad/CMakeFiles/yarp_SDLJoypad.dir/build.make:125: recipe for target 'lib/yarp/yarp_SDLJoypad.so' failed
make[5]: *** [lib/yarp/yarp_SDLJoypad.so] Error 1
CMakeFiles/Makefile2:2417: recipe for target 'src/devices/SDLJoypad/CMakeFiles/yarp_SDLJoypad.dir/all' failed
make[4]: *** [src/devices/SDLJoypad/CMakeFiles/yarp_SDLJoypad.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make[3]: *** [all] Error 2
CMakeFiles/YARP.dir/build.make:108: recipe for target 'robotology/YARP/CMakeFiles/YCMStamp/YARP-build' failed
make[2]: *** [robotology/YARP/CMakeFiles/YCMStamp/YARP-build] Error 2
CMakeFiles/Makefile2:68: recipe for target 'CMakeFiles/YARP.dir/all' failed
make[1]: *** [CMakeFiles/YARP.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

I don't know what is the reason but I got the following warning when I did cmake

CMake Warning (dev) at build/CMakeFiles/YCMEPHelper.cmake:171 (message):
YCM_BOOTSTRAP HASH mismatch
 for file: [/home/vpasandi/Documents/repositories/robotology-superbuild/cmake/IncludeUrl.cmake]
   expected hash: [e31dffed0897729283ef4e945bbdeb1921b438b5]
     actual hash: [ae6de83398115e5b8fd6c261972dea82d1aeb3fd]
Perhaps it is outdated or you have local modification. Please consider
upgrading it, or contributing your changes to YCM.

Call Stack (most recent call first):
build/CMakeFiles/YCMEPHelper.cmake:1330 (_ycm_hash_check)
cmake/YCMBootstrap.cmake:114 (ycm_bootstrap)
CMakeLists.txt:104 (include)
This warning is for project developers. Use -Wno-dev to suppress it.

The text was updated successfully, but these errors were encountered:

triccyx · 2019-04-01T16:10:51Z

I had the same issue, @Nicogene was able to workaround the problem with a trick.

Get version from commit robotology/ycm-cmake-modules@3dcadbd, released as part of YCM 0.10 . Solve the warning mentioned in #191

traversaro · 2019-04-01T17:43:20Z

Reproduced locally in my PC, the problem was not affecting Travis only because on Travis libsdl1.2-dev is not installed.

traversaro · 2019-04-01T17:43:54Z

I don't know what is the reason but I got the following warning when I did cmake

That is unrelated, it should be fixed by #193 .

traversaro · 2019-04-01T17:59:29Z

A workaround for this issue is this modification: b6ed1b3 .

traversaro · 2019-04-01T20:49:29Z

The problem is that for some reason this line in the upstream FindSDL.cmake is finding /usr/lib/x86_64-linux-gnu/libSDL.a instead of /usr/lib/x86_64-linux-gnu/libSDL.so, and then passing a package static library (compiled without -fPIC) cause the error.

I have no idea what is going on, but with YCM 0.8.0 the find_library founds the correct library /usr/lib/x86_64-linux-gnu/libSDL.so.

traversaro · 2019-04-01T20:52:03Z

cc @drdanz

traversaro · 2019-04-01T21:03:29Z

It may be worth to try to create a minimal working example and if we are able to do so, move the bug in YCM.

traversaro · 2019-04-01T22:34:28Z

I found the root cause. On YCM 0.8, CMAKE_FIND_LIBRARY_SUFFIXES has the correct value .so;.a: the precedence of .so is what ensure that dynamic libraries are found before static ones. With YCM 0.10, CMAKE_FIND_LIBRARY_SUFFIXES has the wrong value .a, meaning that find_library only looks for static libraries.
This is caused by the call to the FindGLEW script in https://github.com/robotology/yarp/blob/master/cmake/YarpFindDependencies.cmake#L420 : moving the find_package(GLEW QUIET) call after find_package(SDL QUIET) and cleaning the cache solves the problem. The problem was introduced by https://gitlab.kitware.com/cmake/cmake/merge_requests/3094, that introduced some set(CMAKE_FIND_LIBRARY_SUFFIXES ".a" PARENT_SCOPE) calls in the FindGLEW.cmake script, that corrupt the CMAKE_FIND_LIBRARY_SUFFIXES variable also outside the context of the FindGLEW.cmake script. This file has been imported in YCM with PR robotology/ycm-cmake-modules#226 .

cc @drdanz @claudiofantacci

claudiofantacci · 2019-04-02T06:22:04Z

If this is the case, then I have to fix this upstream asap.

claudiofantacci · 2019-04-02T07:26:08Z

Ok, you can replicate this issue by simply running this:

cmake_minimum_required(VERSION 3.5)

project(prova_glew)

find_package(YCM 0.10.0 REQUIRED)

message(STATUS "CMAKE_FIND_LIBRARY_SUFFIXES: ${CMAKE_FIND_LIBRARY_SUFFIXES}")

find_package(GLEW REQUIRED)

message(STATUS "CMAKE_FIND_LIBRARY_SUFFIXES: ${CMAKE_FIND_LIBRARY_SUFFIXES}")

I'll fix this upstream and post here the fix. It should be a matter of adding two lines in FindGLEW.cmake.

claudiofantacci · 2019-04-02T07:36:35Z

To fix this issue, open <YCM build/installation dir>/share/YCM/cmake-next/Modules/FindGLEW.cmake and replace these lines with the following:

set(USER_FIND_LIBRARY_SUFFIXES ${CMAKE_FIND_LIBRARY_SUFFIXES})

__glew_set_find_library_suffix(SHARED)

find_library(GLEW_SHARED_LIBRARY_RELEASE
             NAMES GLEW glew glew32
             PATH_SUFFIXES lib lib64 libx32 lib/Release/${_arch}
             PATHS ENV GLEW_ROOT)

find_library(GLEW_SHARED_LIBRARY_DEBUG
             NAMES GLEWd glewd glew32d
             PATH_SUFFIXES lib lib64
             PATHS ENV GLEW_ROOT)


__glew_set_find_library_suffix(STATIC)

find_library(GLEW_STATIC_LIBRARY_RELEASE
             NAMES GLEW glew glew32s
             PATH_SUFFIXES lib lib64 libx32 lib/Release/${_arch}
             PATHS ENV GLEW_ROOT)

find_library(GLEW_STATIC_LIBRARY_DEBUG
             NAMES GLEWds glewds glew32ds
             PATH_SUFFIXES lib lib64
             PATHS ENV GLEW_ROOT)

set(CMAKE_FIND_LIBRARY_SUFFIXES ${USER_FIND_LIBRARY_SUFFIXES})

Since FindGLEW.cmake is downloaded from upstream CMake, be sure to apply this patch every time the file is changed by the build/installation process.

I'm opening a PR upstream to get this fixed once and for all.

claudiofantacci · 2019-04-02T07:49:47Z

Upstream PR: https://gitlab.kitware.com/cmake/cmake/merge_requests/3179

Sorry for the inconvenience this may caused and thanks for your help in detecting this issue 🥇

VenusPasandi · 2019-04-02T14:00:47Z

A workaround for this issue is this modification: b6ed1b3

@traversaro, using this trick, I did a clean installation (I mean without any error)!

claudiofantacci · 2019-04-04T15:46:09Z

The fix was merged upstream 🎉

We now need to update the YCM, cc @drdanz

drdanz · 2019-04-05T07:00:05Z

Thanks @traversaro for debugging and @claudiofantacci for the fix! Imported it in YCM. I will import it in YARP as soon as I release YCM 0.10.1.

traversaro · 2019-04-05T10:26:44Z

As it can be verified by #198, the bootstrapped version has been fixed. I will wait for YCM 0.10.1 release to had the 0.10.1 YCM version as a requirement and close this issue.

drdanz · 2019-04-08T05:38:01Z

YCM 0.10.1 just released

traversaro added a commit that referenced this issue Apr 1, 2019

Update YCM's IncludeUrl.cmake to latest version

48a8d4b

Get version from commit robotology/ycm-cmake-modules@3dcadbd, released as part of YCM 0.10 . Solve the warning mentioned in #191

traversaro mentioned this issue Apr 1, 2019

Update YCM's IncludeUrl.cmake to latest version #193

Merged

traversaro changed the title ~~[Make Error] recipe for target 'all' failed~~ YARP shared library is linked against static system libSDL.a instead of libSDL.so Apr 1, 2019

traversaro mentioned this issue Apr 2, 2019

Bump required YCM version (v0.10+) roboticslab-uc3m/questions-and-answers#82

Closed

traversaro mentioned this issue Apr 5, 2019

Align dependencies installed in Travis with the dependencies mentioned in the README #198

Merged

traversaro mentioned this issue May 3, 2019

Use v0.10.2 of YCM #199

Merged

traversaro closed this as completed in #199 May 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARP shared library is linked against static system libSDL.a instead of libSDL.so #191

YARP shared library is linked against static system libSDL.a instead of libSDL.so #191

VenusPasandi commented Apr 1, 2019

triccyx commented Apr 1, 2019 •

edited

Loading

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

VenusPasandi commented Apr 2, 2019

claudiofantacci commented Apr 4, 2019

drdanz commented Apr 5, 2019

traversaro commented Apr 5, 2019

drdanz commented Apr 8, 2019 •

edited

Loading

YARP shared library is linked against static system libSDL.a instead of libSDL.so #191

YARP shared library is linked against static system libSDL.a instead of libSDL.so #191

Comments

VenusPasandi commented Apr 1, 2019

triccyx commented Apr 1, 2019 • edited Loading

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

traversaro commented Apr 1, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

claudiofantacci commented Apr 2, 2019

VenusPasandi commented Apr 2, 2019

claudiofantacci commented Apr 4, 2019

drdanz commented Apr 5, 2019

traversaro commented Apr 5, 2019

drdanz commented Apr 8, 2019 • edited Loading

triccyx commented Apr 1, 2019 •

edited

Loading

drdanz commented Apr 8, 2019 •

edited

Loading