Update README documentation #108
Conversation
README.md
Outdated
| @@ -51,9 +51,10 @@ Eprint = {arXiv:1809.02167}, | |||
| * [YARP](http://www.yarp.it/): to handle the comunication with the robot; | |||
| * [iDynTree](http://wiki.icub.org/codyco/dox/html/idyntree/html/): to handle the robot kinematics; | |||
| * [iCubContrib](https://github.com/robotology/icub-contrib-common): to configure the modules; | |||
| * [icub-main](https://github.com/robotology/icub-main): to handle signale processing; | |||
There was a problem hiding this comment.
As far as I see icub-main is used only for the min-jerk-trajectory and the integrator. I didn't know hot to describe it. @S-Dafarra @GiulioRomualdi feel free to suggest better description of it.
There was a problem hiding this comment.
(I also noticed probably this include
is not required
There was a problem hiding this comment.
Feel free to remove it and add that modification to this PR
There was a problem hiding this comment.
Removing those lines I am getting the following compilation error
In file included from /Users/lorenzorapetti/Software/robotology-superbuild/src/walking-controllers/src/SimplifiedModelControllers/src/ZMPController.cpp:18:
/Users/lorenzorapetti/Software/robotology-superbuild/src/walking-controllers/src/SimplifiedModelControllers/include/WalkingControllers/SimplifiedModelControllers/ZMPController.h:60:37: error: no member named 'Integrator' in namespace 'iCub::ctrl'
std::unique_ptr<iCub::ctrl::Integrator> m_velocityIntegral{nullptr};
~~~~~~~~~~~~^
/Users/lorenzorapetti/Software/robotology-superbuild/src/walking-controllers/src/SimplifiedModelControllers/src/ZMPController.cpp:65:55: error: no member named 'Integrator' in namespace 'iCub::ctrl'
m_velocityIntegral = std::make_unique<iCub::ctrl::Integrator>(samplingTime, buffer);
~~~~~~~~~~~~^
Indeed iCub::ctrl::Integrator is included in iCub/ctrl/pids.h (see https://github.com/robotology/icub-main/blob/a210d2e74b069c3df356098de5748be77deb798c/src/libraries/ctrlLib/src/pids.cpp#L28-L38), so we cannot remove it.
README.md
Outdated
| @@ -51,9 +51,10 @@ Eprint = {arXiv:1809.02167}, | |||
| * [YARP](http://www.yarp.it/): to handle the comunication with the robot; | |||
| * [iDynTree](http://wiki.icub.org/codyco/dox/html/idyntree/html/): to handle the robot kinematics; | |||
| * [iCubContrib](https://github.com/robotology/icub-contrib-common): to configure the modules; | |||
| * [icub-main](https://github.com/robotology/icub-main): to handle signale processing; | |||
There was a problem hiding this comment.
Feel free to remove it and add that modification to this PR
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
|
Hi @S-Dafarra the comment should have been addressed, please let me know if any additional change is required |
Accordingly to #102