Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the feetYawDelta and the slowWhenBackwardFactor. #89

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

GiulioRomualdi
Copy link
Member

This PR should be merged after #87

cc @S-Dafarra

@S-Dafarra
Copy link
Collaborator

This PR should be merged after #87

cc @S-Dafarra

And after robotology/unicycle-footstep-planner#41

@S-Dafarra
Copy link
Collaborator

@GiulioRomualdi I cannot add you as a reviewer, but please take a look at the code

@GiulioRomualdi
Copy link
Member Author

I think we can merge it

@GiulioRomualdi
Copy link
Member Author

Let's wait for #87 before merging this PR

@S-Dafarra
Copy link
Collaborator

I just realized that the reason why the robot was not walking straight when using the feetYawDelta, is because the reference coming from the joystick is translated in the "robot frame" by using the foot orientation, while instead it should use the unicycle angle. I will try to fix it, so this is an additional blocking point for this PR.

@S-Dafarra
Copy link
Collaborator

I just realized that the reason why the robot was not walking straight when using the feetYawDelta, is because the reference coming from the joystick is translated in the "robot frame" by using the foot orientation, while instead it should use the unicycle angle. I will try to fix it, so this is an additional blocking point for this PR.

Done in dc33e9a

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Jul 14, 2021

Since #87 contains several rebase, I'm fixing the commits. A rebase should be enought

@GiulioRomualdi
Copy link
Member Author

@S-Dafarra let me know if we can merge it

@S-Dafarra
Copy link
Collaborator

I think so. The main structural change has been introduced in 86792c8, where the logic to transform the references from a local frame to a global frame has been moved in a single place in the computeThread. If it is ok for you we can proceed.

@GiulioRomualdi
Copy link
Member Author

@S-Dafarra seems ok 😃

@GiulioRomualdi GiulioRomualdi merged commit 152c5aa into devel Jul 14, 2021
@GiulioRomualdi GiulioRomualdi deleted the s-dafarra/feetYawDelta branch July 14, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants