Add necessary examples to be linked from frc-docs #49
Comments
|
@mrguisamuel and @BerkeSinanYetkin (or anyone else) if you're interested, now that we have a lot of these examples someone needs to add them to frc-docs? I did one of them at wpilibsuite/frc-docs#2019, but obviously there's a lot more. |
Can't we complete all of them and add them through a grand PR? In my timezone it is already kickoff day, examples we haven't done don't seem like a whole lot of work. Maybe we can divide the workload and finish all of them after kickoff? Also, happy kickoff day everyone! |
|
In my timezone it's almost 1am, and I still have a bunch of stuff left for the RobotPy 2023 release (mostly documentation at this point). :) |
Update getting-started to be inline with upstream examples. as per #49.
Following #49 In `constants.py` file, the constants are grouped in different classes (I don't know if this style will respect the [RobotPy's porting guide](https://github.com/robotpy/examples/blob/main/CONTRIBUTING.md)). In `robotcontainer.py`, I created a function named `moveArm`, to adapt in a single line (two calls in `configureButtonBindings`).
|
seems like we got everything rounded up |
|
Still need all of these, here is the PR to add them. I noticed a few were on the list above as done but I couldn't find them in the directory: |
|
A bunch of those examples are in the commands subdirectory. |
|
That does not seem at all intuitive. I think that should be fixed. There are many other examples that could be grouped but aren't. |
|
They're grouped by the commands dependency. I presume you mean we should group our CV examples (since we don't install OpenCV things on the robot by default)? |
|
Yes, the groupings suck. I like the organization idea in #74? |
|
The list above has been updated |
|
Still need all of these, here is the PR to add them. I noticed a few were on the list above as done but I couldn't find them in the directory:
|
Issue #49 Add the [SwerveBot](https://github.com/wpilibsuite/allwpilib/tree/main/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/swervebot) example. I added a constants.py file to remove redundant imports, since the original Java example doesn't have a Constants.java. --------- Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com>
Issue #49 Original example [is here](https://github.com/wpilibsuite/allwpilib/tree/main/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/statespaceflywheelsysid) --------- Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com>
|
Could state space elevator be checked off please? I accidentally ported the example when it was already written because I just looked at the list and my clone of the repo hadn't updated |
Addresses issue #49 [Axis Camera Sample](https://github.com/wpilibsuite/allwpilib/tree/main/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/axiscamera) necessity! Could someone with a rio test the Axis Camera code because, I do not have a rio or an axis camera currently. --------- Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com>
|
Should be updated now. |
|
The XRP Reference might need to be ported for the vscode-wpilib reference example: |
#49 Added the ```StateSpaceArm``` and ```StateSpaceElevator``` examples from Java. I did some adaptations in ```StateSpaceFlywheel```, it's considering the porting guide.
If RobotPy is to be included in frc-docs (see initial PR), then we need to have existing working examples that can be linked to from the documentation that match the WPILib examples closely. By running the following on frc-docs:
I get the following examples required:
Here are additional examples that need to be created too:
[ ] DMAI tried using ChatGPT to do automated translation of examples, and it's pretty good! Here's a prompt I started with that I got reasonable results with:
The text was updated successfully, but these errors were encountered: