-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
low hanging fruit #91
Conversation
0f036d5
to
0d0f64d
Compare
It's becoming more apparent as I look through more and more of these examples, that there's a few different styles at play. I've been creating class-level constants with all-caps snakecase, but I see others following the k-prefix camelcase style. There are also a few others that define them in robotInit() instead of the class itself. Is there a specific style you'd prefer to follow? I know the k-prefix is commonly used elsewhere in wpilib, but I've found the all-caps style to be more common in my professional experience. That said, I don't hold any strong opinions here. I'm happy to go update the ones I've already done. |
0d0f64d
to
15a6baf
Compare
Generally we follow the Java wpilib conventions, which uses k-prefix style. I don't care that much about which it is. |
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
I'll stop adding to this so it can be properly reviewed. All the checks are green, so should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are conflicts because of your file header changes.
6f7a944
to
61f2f7c
Compare
Some new examples:
Also reformated/updated a few existing ones to be more consistent with java examples