This repository was archived by the owner on Jan 4, 2023. It is now read-only.
Rename protected methods to retain pre-2020 backwards compat #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. ironically a breaking change for 2020 which I don't usually do in the middle of the season, but long term this is better?
@picode98 and @benjiboy50fonz do you have opinions on this? The effect would be most of the command stuff would be back as it was previously, instead of protected methods starting with underscores.
@auscompgeek may also have sage advice.