Skip to content
This repository was archived by the owner on Jan 4, 2023. It is now read-only.

Conversation

virtuald
Copy link
Member

.. ironically a breaking change for 2020 which I don't usually do in the middle of the season, but long term this is better?

@picode98 and @benjiboy50fonz do you have opinions on this? The effect would be most of the command stuff would be back as it was previously, instead of protected methods starting with underscores.

@auscompgeek may also have sage advice.

.. ironically a breaking change for 2020, but long term this is better?
@auscompgeek
Copy link
Member

I think this mostly makes sense: this is, for the most part, the "public" interface.

Might be better to just have a switch at the class level to turn off the protected prefixing though (and/or at the package level).

@FRC2539
Copy link

FRC2539 commented Jan 26, 2020

We vote to remove the underscores

@virtuald virtuald merged commit bc279e5 into master Jan 27, 2020
@virtuald virtuald deleted the rename-protected branch January 27, 2020 06:08
@picode98
Copy link

For functions like _execute and _isFinished in Command, implementing them as public members makes more sense to me, especially since the scheduler (an external class) is calling them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants