Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .krew.yaml #23

Closed
wants to merge 1 commit into from

Conversation

rajatjindal
Copy link
Contributor

fixes #20

Once this PR is merged, please configure the webhook using instructions here: https://github.com/rajatjindal/krew-release-bot#how-to-install

Look forward for seeing this in action for your repo. happy to help, if you runs into any issue with this.

Thanks
Rajat Jindal

@rajatjindal
Copy link
Contributor Author

I ran it locally using latest release, and got this yaml file:

apiVersion: krew.googlecontainertools.github.com/v1alpha2
kind: Plugin
metadata:
  name: resource-capacity
spec:
  version: v0.3.3
  homepage: https://github.com/robscott/kube-capacity
  shortDescription: Provides an overview of resource requests, limits, and utilization
  platforms:
  - selector:
      matchLabels:
        os: darwin
        arch: amd64
    bin: kube-capacity
    files:
    - from: "*"
      to: "."
    uri: https://github.com/robscott/kube-capacity/releases/download/0.3.3/kube-capacity_0.3.3_Darwin_x86_64.tar.gz
    sha256: 539747ab82ebfec72c3340c40661fdfd62108a5d305dbf5a7e43f9ca6428748b    
  - selector:
      matchLabels:
        os: linux
        arch: amd64
    bin: kube-capacity
    files:
    - from: "*"
      to: "."
    uri: https://github.com/robscott/kube-capacity/releases/download/0.3.3/kube-capacity_0.3.3_Linux_x86_64.tar.gz
    sha256: 7869bfe301e471a9e1cf539b4a9062b672cc5d71a08da510ed6ca7aaaf7c7c46
  description: |
    A simple CLI that provides an overview of the resource requests, limits, and utilization in a Kubernetes cluster.

@rajatjindal
Copy link
Contributor Author

This is obsolete after we did iterations of recommendations from krew team. I will open a new PR soon for you. Thanks

@robscott
Copy link
Owner

Hey @rajatjindal, thanks for your work on this! Let me know if you're able to get the new approach working.

@rajatjindal
Copy link
Contributor Author

yes, we got that working. I will try to find time this week to submit new PR for this.

@rajatjindal
Copy link
Contributor Author

Hi Rob,

I looked at the repo, and couldn't make out how the release are being created. I am guessing you are running go-releaser manually to create the release? and also packaging this for brew.

If my understanding is right, let me know how would you like to prefer this setup. there are a few options I can think of:

  • update circle-ci to call go-releaser and create the release. We will also update circle-ci to run krew-release-bot after that.
  • move the CI to use github actions (we have tested this with other plugins)

if my understanding is wrong, could you please help me understand how the releases are done, and I will think of how krew-release-bot will integrate with that process.

Many thanks
Rajat Jindal

@robscott
Copy link
Owner

robscott commented Feb 1, 2020

Hey @rajatjindal, thanks for your help with this! You're right, all releases have been done manually at this point, just by running goreleaser. Very open to other approaches, either CircleCI or GitHub actions.

@rajatjindal
Copy link
Contributor Author

closing in favor of #26

@rajatjindal rajatjindal closed this Feb 1, 2020
@rajatjindal rajatjindal deleted the krew-release-bot branch February 1, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using krew-plugin-release to bump krew-index
2 participants