Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

club soda testing #5

Closed
RobStallion opened this issue Jan 11, 2019 · 7 comments
Closed

club soda testing #5

RobStallion opened this issue Jan 11, 2019 · 7 comments

Comments

@RobStallion
Copy link
Owner

RobStallion commented Jan 11, 2019

putting this issue here as I didn't want to clutter the cs repo. Can copy over afterwards if needed

@RobStallion
Copy link
Owner Author

RobStallion commented Jan 11, 2019

changing the db from my local copy to prod copy. Using copy of prod from 4 hours ago today

@RobStallion
Copy link
Owner Author

club-soda/club-soda-guide#358 this was the last commit merged into master when I started testing.

Ran the following on the latest prod db copy.

club-soda-guide git:(master) ✗ mix ecto.migrate
[info] Already up

Good start

@RobStallion
Copy link
Owner Author

RobStallion commented Jan 11, 2019

going to try and follow the router so that I don't miss any endpoints

passed

scope /

  • / search bar and use my location work.
  • /brands/Double-Dutch-Drinks
  • /drinks
    • resources("/drinks", DrinkController, only: [:show]) not sure how to get to this route.
    • tried drink/id and drink/entry_id.
    • got sent link which seems to work /drinks/749a0267-381d-4134-934a-cd2ca0c2a2ff
  • /users/new (kind of pass. submits to signup which is erroring. This page is fine though)
  • /users [create]
  • /venues/:slug
  • /sessions [new/create both fine]
  • / json_drinks

scope /search

  • /drinks
    • drinks display fine. filter by abv works. drink type filter also seems to work. Also links on back of cards. (no images but that should happen)
    • /venues both filters working and links work (no images but should be good)
    • /venue/all

failed

/signup [create]
failing because the slug is not being created for this endpoint...

#Ecto.Changeset<
  action: nil,
  changes: %{},
  errors: [
    venue_name: {"can't be blank", [validation: :required]},
    postcode: {"can't be blank", [validation: :required]},
    slug: {"can't be blank", [validation: :required]}
  ],
  data: #CsGuide.Resources.Venue<>,
  valid?: false
>

@SimonLab is aware and is fixing this

@RobStallion
Copy link
Owner Author

working

score /admin

/ and all the index pages from / work

@RobStallion
Copy link
Owner Author

Trying to upload an image to a venue but it is not appearing at the moment

@RobStallion
Copy link
Owner Author

It's fine. Image comes from s3

@nelsonic
Copy link
Collaborator

@RobStallion this kind of testing walkthrough is absolutely worth having in the main project! Please put it in /test/README.md 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants