Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate fluent-en_GB SmokeTest from spek to kotest #1202

Closed
2 tasks
robstoll opened this issue Oct 5, 2022 · 1 comment · Fixed by #1205
Closed
2 tasks

migrate fluent-en_GB SmokeTest from spek to kotest #1202

robstoll opened this issue Oct 5, 2022 · 1 comment · Fixed by #1205
Assignees
@Dark-Knight11
Labels
good first issue Good for newcomers hacktoberfest help wanted
Milestone
1.0.0

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 5, 2022 •
edited

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

We want to move away from spek as it's future regarding maintenance and development is quite unsure.
As I don't want to loose hierarchical test setup I decided that we go with kotest

Following the things you need to do:

  • add dependency to kotest in misc/atrium-specs/build.gradle.kts
  • rewrite bundles/fluent-en_GB/atrium-fluent-en_GB/src/jvmTest/kotlin/custom/SmokeSpec.kt to kotest extending a DescribeSpec

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll closed this as completed Oct 5, 2022
@robstoll robstoll reopened this Oct 5, 2022
@Dark-Knight11
Copy link
Contributor

I'll work on this

Dark-Knight11 added a commit to Dark-Knight11/atrium that referenced this issue Oct 18, 2022
@Dark-Knight11
Migrate fluent-en_GB SmokeTest from spek to kotest
97c0876 
Migrated the SmokeSpec file from Spek to Kotest using Descibe Spec.
Used Kotest version 4.2.3. In the latest Kotest Versions,
min kotlin version is limited to 1.6 but atrium uses kotlin 1.3.2.
Kotest 4.3.2 is the last version which is compatible with kotlin 1.3.x
Will have to bump these version once Kotlin version is updated here.

Resolves: robstoll#1202
@Dark-Knight11 Dark-Knight11 mentioned this issue Oct 18, 2022
Merged
@robstoll robstoll added this to the 0.19.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dark-Knight11 Dark-Knight11

Labels
good first issue Good for newcomers hacktoberfest help wanted
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Smoke Spec Dark-Knight11/atrium
2 participants
@robstoll @Dark-Knight11