Smoke Spec #1205
Merged
Smoke Spec #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
requested changes
Oct 17, 2022
There was a problem hiding this comment.
@Dark-Knight11 Thanks for the WIP was able to figure out the problem by debugging (in case you want to try it out as well. Set a break-point in io.kotest.framework.discovery.Discovery#doDiscovery)
bundles/fluent-en_GB/atrium-fluent-en_GB/src/jvmTest/kotlin/custom/SmokeSpec.kt
Outdated
Show resolved
Hide resolved
Bumps [scala-library](https://github.com/scala/scala) from 2.13.2 to 2.13.10. - [Release notes](https://github.com/scala/scala/releases) - [Commits](scala/scala@v2.13.2...v2.13.10) --- updated-dependencies: - dependency-name: org.scala-lang:scala-library dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `junit.version` from 5.9.0 to 5.9.1. Updates `junit-jupiter` from 5.9.0 to 5.9.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.0...r5.9.1) Updates `junit-jupiter-engine` from 5.9.0 to 5.9.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.0...r5.9.1) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Migrated the SmokeSpec file from Spek to Kotest using Descibe Spec. Used Kotest version 4.2.3. In the latest Kotest Versions, min kotlin version is limited to 1.6 but atrium uses kotlin 1.3.2. Kotest 4.3.2 is the last version which is compatible with kotlin 1.3.x Will have to bump these version once Kotlin version is updated here. Resolves: robstoll#1202
robstoll
requested changes
Oct 18, 2022
There was a problem hiding this comment.
@Dark-Knight11 just a tiny correction and we are good to merge
| @@ -16,11 +18,16 @@ kotlin { | |||
| api(prefixedProject("translations-en_GB")) | |||
| } | |||
| } | |||
| val commonTest by getting { | |||
| dependencies { | |||
| implementation("io.kotest:kotest-runner-junit5:$kotestVersion") // for kotest framework | |||
There was a problem hiding this comment.
Did not think about this beforehand. Use implementationWithExclude this way we don't accidentally use the Kotlin version of kotest
There was a problem hiding this comment.
This way
implementation("io.kotest:kotest-runner-junit5:$kotestVersion") {
exclude(group = "org.jetbrains.kotlin", module = "kotlin-stdlib-jdk8")
}or this way?
implementationWithExclude("io.kotest:kotest-runner-junit5:$kotestVersion") This way we don't accidentally use the Kotlin version of kotest Related: 1202
robstoll
approved these changes
Oct 18, 2022
|
@Dark-Knight11 thanks for your first contribution to Atrium 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated smoke test from Spek to Kotest
Closes: #1202
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.