Skip to content

fix[vdpu383]: fix uninitialized fbc_hdr_stride #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix[vdpu383]: fix uninitialized fbc_hdr_stride #736

wants to merge 1 commit into from

Conversation

nyanmisaka
Copy link
Contributor

Fixes aaa4c8e for rk3576 av1d rkfbc use case.

Otherwise it crashes the RGA driver.

rk_iommu 27920f00.iommu: Page fault at 0x0000000002010040 of type read
rk_iommu 27920f00.iommu: iova = 0x0000000002010040: dte_index: 0x8 pte_index: 0x10 page_offset: 0x40
rk_iommu 27920f00.iommu: mmu_dte_addr: 0x00000000434c3000 dte@0x00000000434c3020: 0x000000 valid: 0>
rga: 0      0     : IOMMU intr fault, IOVA[0x2010040], STATUS[0x24b]
rga: 0      0     : RGA2_core0[0x4] soft reset complete.
rga: 0      0     : RGA IOMMU: page fault! Please check the memory size.
rk_iommu 27920f00.iommu: Page fault at 0x0000000002020080 of type read
rk_iommu 27920f00.iommu: iova = 0x0000000002020080: dte_index: 0x8 pte_index: 0x20 page_offset: 0x80
rk_iommu 27920f00.iommu: mmu_dte_addr: 0x00000000434c3000 dte@0x00000000434c3020: 0x000000 valid: 0>
rga: 0      0     : IOMMU intr fault, IOVA[0x2020080], STATUS[0x24b]
rga: 0      0     : RGA2_core0[0x4] soft reset complete.
rga: 0      0     : RGA IOMMU: page fault! Please check the memory size.
rk_iommu 27920f00.iommu: Page fault at 0x00000000f960c830 of type read
rk_iommu 27920f00.iommu: iova = 0x00000000f960c830: dte_index: 0x3e5 pte_index: 0x20c page_offset: >
rk_iommu 27920f00.iommu: mmu_dte_addr: 0x00000000434c3000 dte@0x00000000434c3f94: 0x000000 valid: 0>
rga: 0      0     : IOMMU intr fault, IOVA[0xf960c830], STATUS[0x24b]
rga: 0      0     : RGA2_core0[0x4] soft reset complete.
rga: 0      0     : RGA IOMMU: page fault! Please check the memory size.
rk_iommu 27920f00.iommu: Page fault at 0x00000000f7615850 of type read
rk_iommu 27920f00.iommu: iova = 0x00000000f7615850: dte_index: 0x3dd pte_index: 0x215 page_offset: >
rk_iommu 27920f00.iommu: mmu_dte_addr: 0x00000000434c3000 dte@0x00000000434c3f74: 0x000000 valid: 0>
rga: 0      0     : IOMMU intr fault, IOVA[0xf7615850], STATUS[0x24b]
rga: 0      0     : RGA2_core0[0x4] soft reset complete.
rga: 0      0     : RGA IOMMU: page fault! Please check the memory size.

cc @HermanChen

@nyanmisaka
fix[vdpu383]: fix uninitialized fbc_hdr_stride
c419c4a 
Fixes aaa4c8e for rk3576 av1d rkfbc use case.

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
HermanChen pushed a commit that referenced this pull request Dec 11, 2024
@VicLiDev
fix[av1d]: Fix uninitialized fbc_hdr_stride issue
330cf90 
From: #736

Reported-by: nyanmisaka <nst799610810@gmail.com>

Change-Id: Ib2a1354b06df9524c164a3f41d58944df49ea1b3
Signed-off-by: Hongjin Li <vic.hong@rock-chips.com>
@VicLiDev
Copy link
Contributor

Hi:

Thank you for identifying and fixing this issue. I have reviewed and approved your patch, and
it has been merged into the develop branch.

Thanks

@nyanmisaka nyanmisaka closed this Dec 11, 2024
@nyanmisaka nyanmisaka deleted the fix-vdpu383-av1-fbc-hdr-stride branch December 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyanmisaka @VicLiDev