-
Notifications
You must be signed in to change notification settings - Fork 24
split FinFun and Permutation into List and Vector #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbf1c37
to
b0574ae
Compare
3e73c20
to
4bf8fca
Compare
4bf8fca
to
e83a220
Compare
@proux01 can you help me understand what this CI error means? (I have an overlay that I'd like to test).
|
Dear coq-nix-toolbox maintainers, @CohenCyril @Zimmi48: Can you (easily) help me tell what the CI is complaining about here? See overlay declaration, code. Thanks! |
Sorry for the delayed answer. The message seems to tell that corn didn't compile/install anything. We should try to understand why (maybe they recently modified something in their build system?). |
Indeed the lines
should be something like (c.f. for instance https://github.com/rocq-prover/stdlib/actions/runs/15546209619/job/43768830203 )
But not sure what's happening since your overlay branch still contains the configure.sh file? |
.nix/config.nix
Outdated
rocq-elpi.override.version = "master"; | ||
rocq-elpi.override.elpi-version = "2.0.7"; | ||
rocq-elpi-test.override.version = "master"; | ||
corn.override.version = "andres-erbsen:patch-1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think I found it, could you try moving this line up 6 lines above (just below the comment) so that it is in coq-common-bundles and not in common-bundles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(common-bundles applies to both coq and rocq, and since there is no corn in rocq, strange things happen if we add an empty package there)
929180f
to
7e134e1
Compare
fiat-crypto says |
IIRC (check in .nix/coq-overlays/fiat-crypto) putting an overlay in any other repo than the main one disactivates all the git submodule churn, so you may need to add overlays for those dependencies or something like that. |
Thank you! I don't understand why the behavior arises or how it makes sense, but sure seems to work as you advised. |
Fixes / closes #????