Adding codecov github action #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
reviewed
Jan 7, 2021
.github/workflows/test.yml
Outdated
| run: | | ||
| bash -c '/bin/bash <(curl -s https://codecov.io/bash)' | ||
|
|
||
| # - name: Build |
There was a problem hiding this comment.
this should be uncommented and moved before the codecov action. can't get test coverage if we don't run tests
There was a problem hiding this comment.
can't run tests, if we don't have tests 😆
i'll try to write a couple of tests here at the end of the day if i have time
There was a problem hiding this comment.
I think I'll draft or close this PR until we're ready to actually run some tests.
|
Let's also add the codecov build badge to the README |
|
Closing for now until we have some tests for this collector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.