Skip to content

Commit

Permalink
Cancels the code complete timer when the caret moves to another line
Browse files Browse the repository at this point in the history
Fixes and closes godotengine#68961
  • Loading branch information
alfredbaudisch authored and rohanrhu committed Dec 28, 2022
1 parent 78303d5 commit 2a64add
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions editor/code_editor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,10 @@ void CodeTextEditor::_reset_zoom() {
}

void CodeTextEditor::_line_col_changed() {
if (!code_complete_timer->is_stopped() && code_complete_timer_line != text_editor->get_caret_line()) {
code_complete_timer->stop();
}

String line = text_editor->get_line(text_editor->get_caret_line());

int positional_column = 0;
Expand Down Expand Up @@ -902,6 +906,7 @@ void CodeTextEditor::_line_col_changed() {

void CodeTextEditor::_text_changed() {
if (text_editor->is_insert_text_operation()) {
code_complete_timer_line = text_editor->get_caret_line();
code_complete_timer->start();
}

Expand Down
1 change: 1 addition & 0 deletions editor/code_editor.h
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ class CodeTextEditor : public VBoxContainer {
Label *info = nullptr;
Timer *idle = nullptr;
Timer *code_complete_timer = nullptr;
int code_complete_timer_line = 0;

Timer *font_resize_timer = nullptr;
int font_resize_val;
Expand Down

0 comments on commit 2a64add

Please sign in to comment.