Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving caret does not cancel autocompletion timer #68961

Closed
KoBeWi opened this issue Nov 21, 2022 · 1 comment · Fixed by #69651
Closed

Moving caret does not cancel autocompletion timer #68961

KoBeWi opened this issue Nov 21, 2022 · 1 comment · Fixed by #69651
Labels
bug topic:editor usability
Milestone
4.0

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 21, 2022

Godot version

4.0 11e1c83 / 3.5

System information

Windows 10 x64

Issue description

godot windows editor dev x86_64_Vr9mH4j7QG
The popup shouldn't appear here, because I stopped typing and moved to another line. It makes navigation annoying, because I have to constantly mash Escape :/

Steps to reproduce

  1. Type some text in script editor
  2. Make sure autocompletion is closed
  3. Type some more on the same line
  4. Immediately move to another line
  5. Autocompletion will appear of the new line

Minimal reproduction project

N/A
@alfredbaudisch
Copy link
Contributor

alfredbaudisch commented Dec 6, 2022 •
edited

I faced this recently too, and I have a fix for it already. Will make a PR later today.

alfredbaudisch added a commit to alfredbaudisch/godot that referenced this issue Dec 6, 2022
@alfredbaudisch
Cancels the code complete timer when the caret moves to another line
818e594 
Fixes and closes godotengine#68961
@alfredbaudisch alfredbaudisch mentioned this issue Dec 6, 2022
Merged
@akien-mga akien-mga added this to the 4.0 milestone Dec 6, 2022
DarkMessiah pushed a commit to DarkMessiah/godot that referenced this issue Dec 20, 2022
@alfredbaudisch @DarkMessiah
Cancels the code complete timer when the caret moves to another line
f37fc10 
Fixes and closes godotengine#68961
rohanrhu pushed a commit to rohanrhu/godot that referenced this issue Dec 28, 2022
@alfredbaudisch @rohanrhu
Cancels the code complete timer when the caret moves to another line
2a64add 
Fixes and closes godotengine#68961
rohanrhu pushed a commit to rohanrhu/godot that referenced this issue Dec 28, 2022
@alfredbaudisch @rohanrhu
Cancels the code complete timer when the caret moves to another line
b9b5005 
Fixes and closes godotengine#68961
Streq pushed a commit to Streq/godot that referenced this issue Feb 9, 2023
@alfredbaudisch @Streq
Cancels the code complete timer when the caret moves to another line
ecd3f40 
Fixes and closes godotengine#68961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Cancels the code complete timer when the caret moves to another line alfredbaudisch/godot
3 participants
@alfredbaudisch @KoBeWi @akien-mga