fix: resolve the stagingDir option relative to the bsconfig.json file #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
approved these changes
May 7, 2024
TwitchBronBron
added a commit
that referenced
this pull request
May 13, 2024
* Add plugin hook for documentSymbol (#1116) * Add plugin hook for documentSymbol * Better handling of null/missing name tokens * fix lint issues * Upgade LSP packages (#1117) * Plugin hook provide workspace symbol (#1118) * Move symbol creation to symbolUtils * Fix workspaceSymbol handling * Fix tests * Fix lint issues * Improve workspace/document symbol handling (#1120) * Move symbol creation to symbolUtils * Fix workspaceSymbol handling * Fix tests * Fix lint issues * Mostly fixed tests * Fix workspace symbols missing containerName * Update changelog for v0.65.27 * 0.65.27 * Upgrade to @rokucommunity/logger (#1137) * Upgrade to @rokucommunity/logger * Add original logger class back * @rokucommunity/logger v0.3.4 * Fix node14 issues (#1153) * Bump tar from 6.1.13 to 6.2.1 in /benchmarks (#1131) Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.13...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bronley Plumb <bronley@gmail.com> * fix: resolve the stagingDir option relative to the bsconfig.json file (#1148) * fix: resolve the stagingDir option relative to the bsconfig.json file * chore: add unit test * Fix windows paths --------- Co-authored-by: Bart van den Ende <bart.van.den.ende@wbd.com> Co-authored-by: Bronley Plumb <bronley@gmail.com> * Move function calls to separate diagnostic (#1169) * Fix formatting with logger output (#1171) * Update changelog for v0.67.0 * 0.67.0 * Fix crash when diagnostic is missing range (#1174) * Fix crash when diagnostic is missing range * improve unit test * Fix issues with cannotFindFunction * Removed TypeChainEntry.kind (#1178) * fixed some tests as well * remove commented out code * Fixed last tests * fix lint errors --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bart van den Ende <65355342+bartvandenende-wm@users.noreply.github.com> Co-authored-by: Bart van den Ende <bart.van.den.ende@wbd.com> Co-authored-by: Mark Pearce <markwpearce@gmail.com> Co-authored-by: Mark Pearce <mark.pearce@redspace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve the stagingDir option relative to the bsconfig.json file
Details
Resolve
stagingDirrelative to thebsconfig.jsonfile similar to the other paths.solves #1141
Repro steps
given the below two config files
{ "extends": "./node_modules/shared-config/bsconfig.json", }Expected result:
How it was tested
unit test