Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the stagingDir option relative to the bsconfig.json file #1148

Conversation

bartvandenende-wm
Copy link
Contributor

Summary

fix: resolve the stagingDir option relative to the bsconfig.json file

Details

Resolve stagingDir relative to the bsconfig.json file similar to the other paths.

⚠️ This is a breaking change in behaviour of the bsconfig.json.

solves #1141

Repro steps

given the below two config files

  1. ./node_modules/shared-config/bsconfig.json
  "rootDir": "../../src",
  "stagingDir": "../../build"
  1. ./bsconfig.json
{
  "extends": "./node_modules/shared-config/bsconfig.json",
}

Expected result:

$ rootDir: {cwd-dir}/src
$ stagingDir: {cwd-dir}/build

How it was tested

unit test

@TwitchBronBron TwitchBronBron merged commit 4bd4a5f into rokucommunity:master May 7, 2024
6 checks passed
TwitchBronBron added a commit that referenced this pull request May 13, 2024
* Add plugin hook for documentSymbol (#1116)

* Add plugin hook for documentSymbol

* Better handling of null/missing name tokens

* fix lint issues

* Upgade LSP packages (#1117)

* Plugin hook provide workspace symbol (#1118)

* Move symbol creation to symbolUtils

* Fix workspaceSymbol handling

* Fix tests

* Fix lint issues

* Improve workspace/document symbol handling (#1120)

* Move symbol creation to symbolUtils

* Fix workspaceSymbol handling

* Fix tests

* Fix lint issues

* Mostly fixed tests

* Fix workspace symbols missing containerName

* Update changelog for v0.65.27

* 0.65.27

* Upgrade to @rokucommunity/logger (#1137)

* Upgrade to @rokucommunity/logger

* Add original logger class back

* @rokucommunity/logger v0.3.4

* Fix node14 issues (#1153)

* Bump tar from 6.1.13 to 6.2.1 in /benchmarks (#1131)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.13...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>

* fix: resolve the stagingDir option relative to the bsconfig.json file (#1148)

* fix: resolve the stagingDir option relative to the bsconfig.json file

* chore: add unit test

* Fix windows paths

---------

Co-authored-by: Bart van den Ende <bart.van.den.ende@wbd.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>

* Move function calls to separate diagnostic (#1169)

* Fix formatting with logger output (#1171)

* Update changelog for v0.67.0

* 0.67.0

* Fix crash when diagnostic is missing range (#1174)

* Fix crash when diagnostic is missing range

* improve unit test

* Fix issues with cannotFindFunction

* Removed TypeChainEntry.kind (#1178)

* fixed some tests as well

* remove commented out code

* Fixed last tests

* fix lint errors

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bart van den Ende <65355342+bartvandenende-wm@users.noreply.github.com>
Co-authored-by: Bart van den Ende <bart.van.den.ende@wbd.com>
Co-authored-by: Mark Pearce <markwpearce@gmail.com>
Co-authored-by: Mark Pearce <mark.pearce@redspace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants