Skip to content

Conversation

buongarzoni
Copy link
Collaborator

@buongarzoni buongarzoni commented Jun 27, 2025

Description of the change

  • Update compile and target SDKs to 33
  • Exclude Android modules from being build with Java 8 but set target compatibility with Java 8
  • Fix compilation error from nebula dependency

Why omit Java 8 run in Android modules

After api 31, Android classes are compiled with Java 9+, this classes contain metadata (that's why we get this error java.lang.AssertionError: annotationType(): unrecognized Attribute name MODULE) which the Java 8 compiler doesn't recognize, so we need to use Java 11 to compile, but we keep compatibility with Java 8 setting the target and source compatibility .

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@buongarzoni buongarzoni added this to the v2.1.0 milestone Jun 27, 2025
@buongarzoni buongarzoni self-assigned this Jun 27, 2025
Copy link

linear bot commented Jun 27, 2025

@buongarzoni buongarzoni merged commit 6a72e7b into master Jun 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants