Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rollbar v3 #131

Merged
merged 10 commits into from
Mar 21, 2022
Merged

Add support for Rollbar v3 #131

merged 10 commits into from
Mar 21, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR includes the work of @philsturgeon and @tobigumo.

Any more work required to make this library compatible with rollbar/rollbar v3 will also be rolled up into this PR.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

philsturgeon and others added 8 commits March 11, 2022 14:03
Laravel 6 and 7 requires php 7.2 - 8.0, so exclude all php versions after 8.1
Fixing PHP versions of Actions CI in Laravel 6 and 7.
…tions

Bump to rollbar-php v3.1.0 for PHP 8.0 compat
This explicitly checks the previous step before `continue-on-error: true` is applied.
@danielmorell
Copy link
Collaborator Author

The install step is now working. However, we have a test failure that I did not see locally. I will need to dig into that.

@danielmorell
Copy link
Collaborator Author

I have been able to reproduce the error locally.

PHPUnit 9.5.19 #StandWithUkraine

..F                                                                 3 / 3 (100%)

Time: 00:00.080, Memory: 22.00 MB

There was 1 failure:

1) Tests\Feature\LoggingTest::test_log_call_invokes_rollbar_check_ignore
Rollbar check_ignore handler not invoked, suggesting an issue integrating Rollbar into Laravel.
Failed asserting that file "/.tmp.txt" exists.

/var/www/rollbar/rollbar-test-app/tests/Feature/LoggingTest.php:14

FAILURES!
Tests: 3, Assertions: 3, Failures: 1.

Now, I just need to dig into the cause.

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielmorell danielmorell merged commit d7647ff into master Mar 21, 2022
@danielmorell danielmorell deleted the rollbar-v3 branch March 21, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install on Laravel 9.* Unable to install with Laravel 8.* Update to rollbar-php 3.x
4 participants