Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed required minimum stability causing the CI tests to fail #143

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

Our CI tests are failing because composer is trying to only install stable dependencies. Installing rollbar/rollbar-laravel from our a path repository without any version in the composer.json file causes composer to assume its version is dev-master. dev-master has a stability of dev.

To fix this problem I added an arbitrary stable version 1.0.0 to the rollbar/rollbar-laravel package in the test app composer.json file.

The other option would be to change the minimum stability requirement in the test app to dev. However, this could have some unintended side effects if other unstable packages are installed.

The last change is replacing the Try to resolve requirements into an installable set of packages step with the added -W flag on the previous step. It essentially does the same thing but better. This also means we can remove the id and continue-on-error keys.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Feb 24, 2023
Copy link

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 2f7ab6f into master Feb 24, 2023
@danielmorell danielmorell deleted the fixed/ci-composer-require-stable branch February 24, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants