Fixed required minimum stability causing the CI tests to fail #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Our CI tests are failing because composer is trying to only install stable dependencies. Installing
rollbar/rollbar-laravel
from our a path repository without any version in thecomposer.json
file causes composer to assume its version isdev-master
.dev-master
has a stability ofdev
.To fix this problem I added an arbitrary stable version
1.0.0
to therollbar/rollbar-laravel
package in the test appcomposer.json
file.The other option would be to change the minimum stability requirement in the test app to
dev
. However, this could have some unintended side effects if other unstable packages are installed.The last change is replacing the
Try to resolve requirements into an installable set of packages
step with the added-W
flag on the previous step. It essentially does the same thing but better. This also means we can remove theid
andcontinue-on-error
keys.Type of change
Related issues
None
Checklists
Development
Code review