Prevent boot/register if $level == none (reopened) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will helps prevent errors during a first deploy in some cases(e.g.: if the .env file has not been setup until later in the process).
drbyte
reviewed
Sep 8, 2017
src/RollbarServiceProvider.php
Outdated
| $hasConfig = $this->app['config']->has('services.rollbar'); | ||
|
|
||
| return $hasLevel === false || ($hasToken === false && $hasConfig === false); | ||
| } |
There was a problem hiding this comment.
I think this will sufficiently handle the necessary logic:
public function stop()
{
$level = getenv('ROLLBAR_LEVEL') ?: $this->app->config->get('services.rollbar.level', null);
$token = getenv('ROLLBAR_TOKEN') ?: $this->app->config->get('services.rollbar.token', null);
$hasToken = empty($token) === false;
return $hasToken === false || $level === 'none';
}- if token not provided, then don't register
- if level === 'none' then don't register
No need to check for config.services.rollbar as well, as long as we test both getenv and config at same time.
No need to check for empty "level", since line 80 already defaults to 'debug' if no level specified.
This is what I'm using now today after a bunch of testing.
|
LGTM. Applied @drbyte changes and merged to master. |
|
Thanks @tobz-nz and @ArturMoczulski ... this makes setup less cumbersome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reopened PR for an accidentally closed PR #11