Recorder maintains a ready flag #1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Background:
When a replay is triggered before the first full snapshot is emitted, a "must have 3 events" error is raised.
This PR adds a recorder flag to track when the recorder is ready, allowing a warning to be logged rather than an error on this condition.
Notes:
load
event, regardless of how early the record function is called.recordAfter
option can be set by the user toDOMContentLoaded
to allow rrweb to build the full snapshot earlier on that event. This may not be desirable, but the user has the option. https://github.com/rrweb-io/rrweb/blob/master/guide.md#optionsType of change
Checklists
Development