This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
feat: Batch update #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make separated Table component for JSInterview parsing result
added opportunity set assignments fields to each xlsx column
| export default connect( | ||
| mapStateToProps, | ||
| mapDispatchToProps, | ||
| )(BatchUpdate); |
There was a problem hiding this comment.
Please separate the file into simpler components
| <div className={'row justify-content-lg-center'} style={{ marginTop: '20px' }}> | ||
| {this.showOperationsResult()} | ||
| </div> | ||
| <div className={'row justify-content-lg-center'} style={{ marginTop: '20px' }}> |
There was a problem hiding this comment.
Why do you use inline styles?
| <div className="col-md-3"> | ||
| <Dropdown | ||
| defaultValue="Select Task" | ||
| onSelect={(task: any) => this.setState({ selectedTask: task.id })} |
There was a problem hiding this comment.
Don't use arrow functions into render method
| saveTable = async (): Promise<any> => { | ||
| const formData = this.prepareFormDataForSaving(); | ||
|
|
||
| const res = await axios.patch('/api/batch-update/save-table', formData, { |
There was a problem hiding this comment.
Move AJAX query to core/api
| parseTable = async (): Promise<any> => { | ||
| const formData = new FormData(); | ||
| formData.set('table', this.state.files[0]); | ||
| const res = await axios.post('/api/batch-update/parse-table', formData, { |
There was a problem hiding this comment.
Move AJAX query to core/api
| style: cellStyle, | ||
| }, | ||
| { Header: 'Select field', accessor: 'dropdown', style: cellStyle, minWidth: 300 }, | ||
| ]} |
There was a problem hiding this comment.
Create constant for table config
|
|
||
| const cn = classNames(require('./index.scss')); | ||
|
|
||
| class Dropdown extends React.Component<any, any> { |
| return ( | ||
| <ButtonDropdown | ||
| isOpen={this.state.isOpen} | ||
| toggle={() => this.setState((prevState: any) => ({ isOpen: !prevState.isOpen }))} |
There was a problem hiding this comment.
Don't use arrow functions into render method
Shastel
suggested changes
Sep 27, 2018
| }; | ||
| }; | ||
|
|
||
| const mapDispatchToProps = (dispatch: any, props: any): any => { |
There was a problem hiding this comment.
[mapDispatchToProps(dispatch, [ownProps]): dispatchProps] (Object or Function): If an object is passed, each function inside it is assumed to be a Redux action creator. An object with the same function names, but with every action creator wrapped into a dispatch call so they may be invoked directly, will be merged into the component’s props.
| import { makeErrorsList, messageMaker } from '../utils'; | ||
|
|
||
| const dataRetriever = (...what: any[]) => (data: any) => | ||
| what.reduce((needRetrievedData: any[], needValue: any) => needRetrievedData.concat(data[needValue]), []); |
There was a problem hiding this comment.
If i got the point you can do same thing easily with map
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used stubs for Tasks and Assignments parts(they are not implemented; they will be implemented in other tasks, how i understood). So, when they will be implemented need make integration and write tests